mbox series

[0/4] drm/i915/dp_mst: Fix error handling/clean up pointer use

Message ID 20250108151916.491113-1-imre.deak@intel.com (mailing list archive)
Headers show
Series drm/i915/dp_mst: Fix error handling/clean up pointer use | expand

Message

Imre Deak Jan. 8, 2025, 3:19 p.m. UTC
This patchset contains unapplied changes from [1], fixing an error
handling path while adding an MST connector and cleaning up the
intel_connector vs. drm_connector pointer use in intel_dp_mst.c,
addressing the review comments from Jani.

It also uses the driver's standard intel_display::platform.alderlake_p
instead of IS_ALDERLAKE_P(); the latter I noticed while rebasing the
patchset.

Cc: Jani Nikula <jani.nikula@intel.com>

[1] https://lore.kernel.org/all/20241211230328.4012496-1-imre.deak@intel.com

Imre Deak (5):
  drm/i915/dp_mst: Fix error handling while adding a connector
  drm/i915/dp_mst: Use intel_connector vs. drm_connector pointer in
    intel_dp_mst.c
  drm/i915/dp_mst: Simplify using to_intel_display() passing it an
    intel_connector pointer
  drm/i915/dp_mst: Simplify getting a drm_device pointer needed by
    to_i915()
  drm/i915/dp_mst: Use intel_display::platform.alderlake_p instead of
    IS_ALDERLAKE_P()

 drivers/gpu/drm/i915/display/intel_dp_mst.c | 202 ++++++++++----------
 1 file changed, 99 insertions(+), 103 deletions(-)

Comments

Imre Deak Jan. 8, 2025, 6:25 p.m. UTC | #1
On Wed, Jan 08, 2025 at 05:30:20PM +0000, Patchwork wrote:

Hi CI team,

the failure is unrelated to changes, see below.

Thanks,
Imre

> == Series Details ==
> 
> Series: drm/i915/dp_mst: Fix error handling/clean up pointer use
> URL   : https://patchwork.freedesktop.org/series/143259/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_15924 -> Patchwork_143259v1
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_143259v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_143259v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/index.html
> 
> Participating hosts (38 -> 37)
> ------------------------------
> 
>   Missing    (1): fi-snb-2520m 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_143259v1:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live@active:
>     - fi-kbl-7567u:       [PASS][1] -> [DMESG-FAIL][2] +1 other test dmesg-fail
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/fi-kbl-7567u/igt@i915_selftest@live@active.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/fi-kbl-7567u/igt@i915_selftest@live@active.html

The above host doesn't have an MST output, so the change are not related
to the issue. It is:

<3> [331.405068] i915 0000:00:02.0: [drm] *ERROR* live_active_wait i915_active not retired after waiting!
<3> [331.405079] i915 0000:00:02.0: [drm] *ERROR* live_active_wait active __live_active [i915]:__live_retire [i915]
<3> [331.405734] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	count: 0
<3> [331.405741] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	preallocated barriers? no
<3> [331.405964] i915/i915_active_live_selftests: live_active_wait failed with error -22

and seems to match:
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12435

> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_143259v1 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@dmabuf@all-tests:
>     - fi-pnv-d510:        NOTRUN -> [INCOMPLETE][3] ([i915#12904]) +1 other test incomplete
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/fi-pnv-d510/igt@dmabuf@all-tests.html
> 
>   * igt@i915_pm_rpm@module-reload:
>     - bat-rpls-4:         [PASS][4] -> [FAIL][5] ([i915#13401])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
> 
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
>     - fi-pnv-d510:        NOTRUN -> [SKIP][6] +31 other tests skip
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/fi-pnv-d510/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html
> 
>   * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
>     - bat-dg2-11:         [PASS][7] -> [SKIP][8] ([i915#9197]) +3 other tests skip
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@i915_selftest@live:
>     - bat-twl-2:          [ABORT][9] ([i915#12919] / [i915#13397]) -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-twl-2/igt@i915_selftest@live.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-twl-2/igt@i915_selftest@live.html
>     - bat-jsl-3:          [INCOMPLETE][11] ([i915#13241]) -> [PASS][12]
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-jsl-3/igt@i915_selftest@live.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-jsl-3/igt@i915_selftest@live.html
> 
>   * igt@i915_selftest@live@gt_mocs:
>     - bat-twl-2:          [ABORT][13] ([i915#12919]) -> [PASS][14]
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-twl-2/igt@i915_selftest@live@gt_mocs.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-twl-2/igt@i915_selftest@live@gt_mocs.html
> 
>   * igt@i915_selftest@live@gt_pm:
>     - bat-jsl-3:          [DMESG-FAIL][15] ([i915#13132]) -> [PASS][16]
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-jsl-3/igt@i915_selftest@live@gt_pm.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-jsl-3/igt@i915_selftest@live@gt_pm.html
> 
>   * igt@i915_selftest@live@objects:
>     - bat-jsl-3:          [INCOMPLETE][17] -> [PASS][18]
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-jsl-3/igt@i915_selftest@live@objects.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-jsl-3/igt@i915_selftest@live@objects.html
> 
>   * igt@i915_selftest@live@workarounds:
>     - bat-arlh-3:         [DMESG-FAIL][19] ([i915#13393]) -> [PASS][20] +1 other test pass
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>     - {bat-arls-6}:       [DMESG-FAIL][21] ([i915#13393]) -> [PASS][22] +1 other test pass
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/bat-arls-6/igt@i915_selftest@live@workarounds.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/bat-arls-6/igt@i915_selftest@live@workarounds.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_exec_gttfill@basic:
>     - fi-pnv-d510:        [ABORT][23] ([i915#13169]) -> [SKIP][24]
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15924/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
>   [i915#12919]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919
>   [i915#13132]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13132
>   [i915#13169]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13169
>   [i915#13241]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13241
>   [i915#13393]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13393
>   [i915#13397]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13397
>   [i915#13401]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13401
>   [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_15924 -> Patchwork_143259v1
> 
>   CI-20190529: 20190529
>   CI_DRM_15924: 9cbe590862ef629f35ce9f4c2dc5c0a6a4553f48 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8181: 32ed9fc482fee95777054d53b96d19a7e30eaa18 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_143259v1: 9cbe590862ef629f35ce9f4c2dc5c0a6a4553f48 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143259v1/index.html