mbox series

[v5,0/3] drm/i915/xe3lpd: Update bandwidth parameters

Message ID 20250311-xe3lpd-bandwidth-update-v5-0-a95a9d90ad71@intel.com (mailing list archive)
Headers show
Series drm/i915/xe3lpd: Update bandwidth parameters | expand

Message

Gustavo Sousa March 11, 2025, 5:04 p.m. UTC
Bandwidth parameters for Xe3_LPD have been updated with respect to
previous display releases. Encode them into xe3lpd_sa_info and use that
new struct.

Since we are touching intel_bw.c, also take the opportunity convert it
to intel_display.

Changes in v2:
  - Fix typo in patch #2.

Changes in v3:
- Squash patches #1 and #2 into a single one and modify it to convert
  intel_bw.c internally to intel_display (new patch subject is
  "drm/i915/display: Convert intel_bw.c internally to intel_display").
- Add a new patch #2 to convert intel_bw.c externally to intel_display.
- Link to v2: https://lore.kernel.org/r/20250217153550.43909-1-gustavo.sousa@intel.com

Changes in v4:
- Prefer intel_uncore_read() for MCHBAR registers. (Ville)
- Link to v3: https://lore.kernel.org/r/20250307-xe3lpd-bandwidth-update-v3-0-58bbe81f65bf@intel.com

Changes in v5:
- Do not include intel_de.h anymore. (Ville)
- Link to v4: https://lore.kernel.org/r/20250310-xe3lpd-bandwidth-update-v4-0-4191964b034d@intel.com

---
Gustavo Sousa (3):
      drm/i915/display: Convert intel_bw.c internally to intel_display
      drm/i915/display: Convert intel_bw.c externally to intel_display
      drm/i915/xe3lpd: Update bandwidth parameters

 drivers/gpu/drm/i915/display/intel_bw.c            | 440 +++++++++++----------
 drivers/gpu/drm/i915/display/intel_bw.h            |   9 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c         |   3 +-
 .../gpu/drm/i915/display/intel_display_driver.c    |   2 +-
 drivers/gpu/drm/i915/display/skl_watermark.c       |  10 +-
 drivers/gpu/drm/i915/i915_driver.c                 |   2 +-
 drivers/gpu/drm/xe/display/xe_display.c            |   2 +-
 7 files changed, 245 insertions(+), 223 deletions(-)
---
base-commit: f8df428b3850ed87a1e2f3b12b6025328d8a6373
change-id: 20250228-xe3lpd-bandwidth-update-f011599c0c3e

Best regards,

Comments

Gustavo Sousa March 12, 2025, 2:39 p.m. UTC | #1
Quoting Patchwork (2025-03-11 15:45:55-03:00)
>== Series Details ==
>
>Series: drm/i915/xe3lpd: Update bandwidth parameters (rev5)
>URL   : https://patchwork.freedesktop.org/series/144441/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_16263 -> Patchwork_144441v5
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_144441v5 absolutely need to be
>  verified manually.
>  
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_144441v5, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/index.html
>
>Participating hosts (43 -> 43)
>------------------------------
>
>  Additional (1): bat-arlh-2 
>  Missing    (1): fi-snb-2520m 
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_144441v5:
>
>### IGT changes ###
>
>#### Possible regressions ####

Hi, CI Team.

The errors below are not related to my series. Could you please
re-report?

Also, please see my comments below.

>
>  * igt@i915_pm_rpm@module-reload:
>    - bat-adls-6:         [PASS][1] -> [FAIL][2]
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-adls-6/igt@i915_pm_rpm@module-reload.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/bat-adls-6/igt@i915_pm_rpm@module-reload.html
>    - bat-rpls-4:         [PASS][3] -> [FAIL][4]
>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

This maps to
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13901.

>
>  * igt@kms_addfb_basic@too-high:
>    - fi-kbl-8809g:       NOTRUN -> [FAIL][5] +3 other tests fail
>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html

I see amdgpu in the dmesg out. How come?

>
>  * igt@kms_flip@basic-flip-vs-wf_vblank:
>    - bat-apl-1:          [PASS][6] -> [DMESG-WARN][7] +1 other test dmesg-warn
>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16263/bat-apl-1/igt@kms_flip@basic-flip-vs-wf_vblank.html
>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/bat-apl-1/igt@kms_flip@basic-flip-vs-wf_vblank.html

I'm not familiar with LSPCON, but, at a quick glance on where lspcon
functions are called, the error seems unrelated to intel_bw.c, thus
unrelated to this series.

>
>  * igt@kms_force_connector_basic@force-connector-state:
>    - fi-kbl-8809g:       NOTRUN -> [DMESG-WARN][8]
>   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html

Again, amdgpu in the logs here.

>
>  * igt@kms_force_connector_basic@force-edid:
>    - fi-kbl-8809g:       NOTRUN -> [DMESG-FAIL][9]
>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144441v5/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html
>

And amdgpu in the logs here as well.

--
Gustavo Sousa