| Message ID | 20250314-drm-rework-dpcd-access-v4-0-e86ef6fc6d76@oss.qualcomm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/display: dp: add new DPCD access functions | expand |
On Fri, Mar 14, 2025 at 05:19:09PM +0000, Patchwork wrote: > == Series Details == > > Series: drm/display: dp: add new DPCD access functions (rev2) > URL : https://patchwork.freedesktop.org/series/145998/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_16290 -> Patchwork_145998v2 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_145998v2 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_145998v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145998v2/index.html > > Participating hosts (44 -> 43) > ------------------------------ > > Missing (1): fi-snb-2520m > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_145998v2: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@kms_flip@basic-flip-vs-modeset@a-dp1: > - bat-apl-1: [PASS][1] -> [ABORT][2] +1 other test abort > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16290/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145998v2/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html > Hmm, any comments on this one? Is it because of the DPCD code that I changed or due to some other reasons? > > Known issues > ------------ > > Here are the changes found in Patchwork_145998v2 that come from known issues: > > ### IGT changes ### > > #### Possible fixes #### > > * igt@kms_pm_rpm@basic-rte: > - bat-rpls-4: [DMESG-WARN][3] ([i915#13400]) -> [PASS][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16290/bat-rpls-4/igt@kms_pm_rpm@basic-rte.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145998v2/bat-rpls-4/igt@kms_pm_rpm@basic-rte.html > > > [i915#13400]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13400 > > > Build changes > ------------- > > * Linux: CI_DRM_16290 -> Patchwork_145998v2 > > CI-20190529: 20190529 > CI_DRM_16290: 83417b23792d937795320a8804fd97d50c4c6233 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_8274: 8274 > Patchwork_145998v2: 83417b23792d937795320a8804fd97d50c4c6233 @ git://anongit.freedesktop.org/gfx-ci/linux > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145998v2/index.html
Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which compares returned value with the size. As suggested by Jani implement new set of DPCD access helpers, which ignore partial access, always return 0 or an error code. Implement new helpers using existing functions to ensure backwards compatibility and to assess necessity to handle incomplete reads on a global scale. Currently only one possible place has been identified, dp-aux-dev, which needs to handle possible holes in DPCD. This series targets only the DRM helpers code. If the approach is found to be acceptable, each of the drivers should be converted on its own. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- Changes in v4: - Actually dropped the dp-aux-dev patch (Lyude). - Added two missing full stops in linuxdoc (Lyude). - Link to v3: https://lore.kernel.org/r/20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org Changes in v3: - Fixed cover letter (Jani) - Added intel-gfx and intel-xe to get the series CI-tested (Jani) - Link to v2: https://lore.kernel.org/r/20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org Changes in v2: - Reimplemented new helpers using old ones (Lyude) - Reworked the drm_dp_dpcd_read_link_status() patch (Lyude) - Dropped the dp-aux-dev patch (Jani) - Link to v1: https://lore.kernel.org/r/20250117-drm-rework-dpcd-access-v1-0-7fc020e04dbc@linaro.org --- Dmitry Baryshkov (6): drm/display: dp: implement new access helpers drm/display: dp: change drm_dp_dpcd_read_link_status() return value drm/display: dp: use new DCPD access helpers drm/display: dp-cec: use new DCPD access helpers drm/display: dp-mst-topology: use new DCPD access helpers drm/display: dp-tunnel: use new DCPD access helpers drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +- drivers/gpu/drm/display/drm_dp_cec.c | 37 ++- drivers/gpu/drm/display/drm_dp_helper.c | 307 +++++++++------------ drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 ++++--- drivers/gpu/drm/display/drm_dp_tunnel.c | 20 +- drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 4 +- drivers/gpu/drm/msm/dp/dp_ctrl.c | 24 +- drivers/gpu/drm/msm/dp/dp_link.c | 18 +- drivers/gpu/drm/radeon/atombios_dp.c | 8 +- include/drm/display/drm_dp_helper.h | 92 +++++- 11 files changed, 317 insertions(+), 308 deletions(-) --- base-commit: b0894e40afe2bd05d1fda68cc364665ac2b00e09 change-id: 20241231-drm-rework-dpcd-access-b0fc2e47d613 Best regards,