mbox series

[00/10] drm/i915: header cleanup of the day

Message ID cover.1565271681.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915: header cleanup of the day | expand

Message

Jani Nikula Aug. 8, 2019, 1:42 p.m. UTC 
The daily dose of header cleanup. I think I'll settle down for a while after
this one. ;)

BR,
Jani.

Jani Nikula (10):
  drm/i915: remove unused dev_priv->no_aux_handshake
  drm/i915: move add_taint_for_CI() to i915_utils.h
  drm/i915: move I915_STATE_WARN() and _ON() to intel_display.h
  drm/i915: move printing and load error inject to i915_utils.[ch]
  drm/i915: extract i915_perf.h from i915_drv.h
  drm/i915: extract i915_sysfs.h from i915_drv.h
  drm/i915: extract i915_suspend.h from i915_drv.h
  drm/i915: extract i915_memcpy.h from i915_drv.h
  drm/i915: extract gem/i915_gem_stolen.h from i915_drv.h
  drm/i915: extract i915_gem_shrinker.h from i915_drv.h

 drivers/gpu/drm/i915/Makefile                |   1 +
 drivers/gpu/drm/i915/display/intel_display.h |  18 +++
 drivers/gpu/drm/i915/display/intel_dp.c      |   4 -
 drivers/gpu/drm/i915/gem/i915_gem_shrinker.h |  31 ++++
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c   |   1 +
 drivers/gpu/drm/i915/gem/i915_gem_stolen.h   |  35 +++++
 drivers/gpu/drm/i915/gt/intel_gt.c           |   1 -
 drivers/gpu/drm/i915/gt/intel_lrc.c          |   1 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c   |   3 +-
 drivers/gpu/drm/i915/i915_cmd_parser.c       |   1 +
 drivers/gpu/drm/i915/i915_drv.c              |  73 +---------
 drivers/gpu/drm/i915/i915_drv.h              | 146 +------------------
 drivers/gpu/drm/i915/i915_gpu_error.c        |   1 +
 drivers/gpu/drm/i915/i915_memcpy.c           |   2 +-
 drivers/gpu/drm/i915/i915_memcpy.h           |  32 ++++
 drivers/gpu/drm/i915/i915_perf.c             |   1 +
 drivers/gpu/drm/i915/i915_perf.h             |  32 ++++
 drivers/gpu/drm/i915/i915_suspend.c          |   1 +
 drivers/gpu/drm/i915/i915_suspend.h          |  14 ++
 drivers/gpu/drm/i915/i915_sysfs.c            |   1 +
 drivers/gpu/drm/i915/i915_sysfs.h            |  14 ++
 drivers/gpu/drm/i915/i915_utils.c            |  78 ++++++++++
 drivers/gpu/drm/i915/i915_utils.h            |  41 ++++++
 23 files changed, 314 insertions(+), 218 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_shrinker.h
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_stolen.h
 create mode 100644 drivers/gpu/drm/i915/i915_memcpy.h
 create mode 100644 drivers/gpu/drm/i915/i915_perf.h
 create mode 100644 drivers/gpu/drm/i915/i915_suspend.h
 create mode 100644 drivers/gpu/drm/i915/i915_sysfs.h
 create mode 100644 drivers/gpu/drm/i915/i915_utils.c

Comments

Chris Wilson Aug. 8, 2019, 1:54 p.m. UTC | #1 
Quoting Jani Nikula (2019-08-08 14:42:39)
> The daily dose of header cleanup. I think I'll settle down for a while after
> this one. ;)
> 
> BR,
> Jani.
> 
> Jani Nikula (10):
>   drm/i915: remove unused dev_priv->no_aux_handshake
>   drm/i915: move add_taint_for_CI() to i915_utils.h
>   drm/i915: move I915_STATE_WARN() and _ON() to intel_display.h
>   drm/i915: move printing and load error inject to i915_utils.[ch]
>   drm/i915: extract i915_perf.h from i915_drv.h
>   drm/i915: extract i915_sysfs.h from i915_drv.h
>   drm/i915: extract i915_suspend.h from i915_drv.h
>   drm/i915: extract i915_memcpy.h from i915_drv.h
>   drm/i915: extract gem/i915_gem_stolen.h from i915_drv.h
>   drm/i915: extract i915_gem_shrinker.h from i915_drv.h

No complaints,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

I thought I had done a better job of grabbing the GEM stuff and putting
in its dungeon. Obviously I need to join it in the dungeon and throw away
the key.
-Chris
Jani Nikula Aug. 9, 2019, 9:53 a.m. UTC | #2 
On Thu, 08 Aug 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-08-08 14:42:39)
>> The daily dose of header cleanup. I think I'll settle down for a while after
>> this one. ;)
>> 
>> BR,
>> Jani.
>> 
>> Jani Nikula (10):
>>   drm/i915: remove unused dev_priv->no_aux_handshake
>>   drm/i915: move add_taint_for_CI() to i915_utils.h
>>   drm/i915: move I915_STATE_WARN() and _ON() to intel_display.h
>>   drm/i915: move printing and load error inject to i915_utils.[ch]
>>   drm/i915: extract i915_perf.h from i915_drv.h
>>   drm/i915: extract i915_sysfs.h from i915_drv.h
>>   drm/i915: extract i915_suspend.h from i915_drv.h
>>   drm/i915: extract i915_memcpy.h from i915_drv.h
>>   drm/i915: extract gem/i915_gem_stolen.h from i915_drv.h
>>   drm/i915: extract i915_gem_shrinker.h from i915_drv.h
>
> No complaints,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks again, pushed.

> I thought I had done a better job of grabbing the GEM stuff and putting
> in its dungeon. Obviously I need to join it in the dungeon and throw away
> the key.

Yes, there's still a bunch of gem stuff left in i915_drv.h. I just
grabbed some of the low hanging fruit here; I really wouldn't mind if
you finished the job!

BR,
Jani.