| Message ID | cover.1611354210.git.ashutosh.dixit@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Start disabling pread/pwrite ioctl's for future platforms | expand |
On Sat, 23 Jan 2021 05:05:02 -0800, Patchwork wrote: > > [1 <text/plain; utf-8 (7bit)>] > [2 <text/html; utf-8 (7bit)>] > Project List - Patchwork > > Patch Details > > Series: drm/i915: Start disabling pread/pwrite ioctl's for future platforms > URL: https://patchwork.freedesktop.org/series/86199/ > State: failure > Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html > > CI Bug Log - changes from CI_DRM_9671_full -> Patchwork_19470_full > > Summary > > FAILURE > > Serious unknown changes coming with Patchwork_19470_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_19470_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > Possible new issues > > Here are the unknown changes that may have been introduced in Patchwork_19470_full: > > IGT changes > > Possible regressions > > * igt@kms_sequence@queue-busy: > > * shard-skl: PASS -> FAIL This is a unrelated failure and a false positive, the patch should not have any effect on this platform. Seeing a few igt@kms_sequence bugs in gitlab but maybe the signature for this one is a little different. Thanks.
Re-reported. -----Original Message----- From: Dixit, Ashutosh <ashutosh.dixit@intel.com> Sent: Sunday, January 24, 2021 3:55 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Start disabling pread/pwrite ioctl's for future platforms On Sat, 23 Jan 2021 05:05:02 -0800, Patchwork wrote: > > [1 <text/plain; utf-8 (7bit)>] > [2 <text/html; utf-8 (7bit)>] > Project List - Patchwork > > Patch Details > > Series: drm/i915: Start disabling pread/pwrite ioctl's for future > platforms > URL: https://patchwork.freedesktop.org/series/86199/ > State: failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html > > CI Bug Log - changes from CI_DRM_9671_full -> Patchwork_19470_full > > Summary > > FAILURE > > Serious unknown changes coming with Patchwork_19470_full absolutely > need to be verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_19470_full, please notify your bug team to > allow them to document this new failure mode, which will reduce false positives in CI. > > Possible new issues > > Here are the unknown changes that may have been introduced in Patchwork_19470_full: > > IGT changes > > Possible regressions > > * igt@kms_sequence@queue-busy: > > * shard-skl: PASS -> FAIL This is a unrelated failure and a false positive, the patch should not have any effect on this platform. Seeing a few igt@kms_sequence bugs in gitlab but maybe the signature for this one is a little different. Thanks.
The guidance for i915 at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and (b) no existing user mode clients actually use the pread/pwrite interface. In this patch we disable these ioctls for dGfx platforms with the expectation that this will be done for all future platforms (both discrete and integrated). IGT changes which handle this kernel change have also been submitted [1]. [1] https://patchwork.freedesktop.org/series/81384/ Test-with: 20210121083742.46592-1-ashutosh.dixit@intel.com Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Ashutosh Dixit (1): drm/i915: Start disabling pread/pwrite ioctl's for future platforms drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 6 ++++++ drivers/gpu/drm/i915/i915_pci.c | 3 ++- drivers/gpu/drm/i915/intel_device_info.h | 1 + 4 files changed, 10 insertions(+), 1 deletion(-)