mbox series

[v2,0/7] drm/i915/bios: remove vbt ddi_port_info caching

Message ID cover.1630512523.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/bios: remove vbt ddi_port_info caching | expand

Message

Jani Nikula Sept. 1, 2021, 4:09 p.m. UTC
v2 of https://patchwork.freedesktop.org/series/93957/ with the CI issues
fixed (fingers crossed!).

BR,
Jani.

Jani Nikula (7):
  drm/i915/bios: use hdmi level shift directly from child data
  drm/i915/bios: use max tmds clock directly from child data
  drm/i915/bios: use dp max link rate directly from child data
  drm/i915/bios: use alternate aux channel directly from child data
  drm/i915/bios: move ddc pin mapping code next to ddc pin sanitize
  drm/i915/bios: use ddc pin directly from child data
  drm/i915/bios: get rid of vbt ddi_port_info

 drivers/gpu/drm/i915/display/intel_bios.c | 372 +++++++++++-----------
 drivers/gpu/drm/i915/i915_drv.h           |  18 +-
 2 files changed, 187 insertions(+), 203 deletions(-)

Comments

Jani Nikula Sept. 3, 2021, 11:04 a.m. UTC | #1
On Wed, 01 Sep 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> v2 of https://patchwork.freedesktop.org/series/93957/ with the CI issues
> fixed (fingers crossed!).

José, I'd like to get an ack from you on this before applying. I know
it's bound conflict with your in flight series. Thoughts?

BR,
Jani.

>
> BR,
> Jani.
>
> Jani Nikula (7):
>   drm/i915/bios: use hdmi level shift directly from child data
>   drm/i915/bios: use max tmds clock directly from child data
>   drm/i915/bios: use dp max link rate directly from child data
>   drm/i915/bios: use alternate aux channel directly from child data
>   drm/i915/bios: move ddc pin mapping code next to ddc pin sanitize
>   drm/i915/bios: use ddc pin directly from child data
>   drm/i915/bios: get rid of vbt ddi_port_info
>
>  drivers/gpu/drm/i915/display/intel_bios.c | 372 +++++++++++-----------
>  drivers/gpu/drm/i915/i915_drv.h           |  18 +-
>  2 files changed, 187 insertions(+), 203 deletions(-)
Souza, Jose Sept. 3, 2021, 8:21 p.m. UTC | #2
On Fri, 2021-09-03 at 14:04 +0300, Jani Nikula wrote:
> On Wed, 01 Sep 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> > v2 of https://patchwork.freedesktop.org/series/93957/ with the CI issues
> > fixed (fingers crossed!).
> 
> José, I'd like to get an ack from you on this before applying. I know
> it's bound conflict with your in flight series. Thoughts?
> 

If you are okay in adding more data at the end of intel_bios_encoder_data we should be fine.
Information from other VBT blocks will need to be added to intel_bios_encoder_data.

It will badly conflict with series but any redundant byte saved is worthy.

> BR,
> Jani.
> 
> > 
> > BR,
> > Jani.
> > 
> > Jani Nikula (7):
> >   drm/i915/bios: use hdmi level shift directly from child data
> >   drm/i915/bios: use max tmds clock directly from child data
> >   drm/i915/bios: use dp max link rate directly from child data
> >   drm/i915/bios: use alternate aux channel directly from child data
> >   drm/i915/bios: move ddc pin mapping code next to ddc pin sanitize
> >   drm/i915/bios: use ddc pin directly from child data
> >   drm/i915/bios: get rid of vbt ddi_port_info
> > 
> >  drivers/gpu/drm/i915/display/intel_bios.c | 372 +++++++++++-----------
> >  drivers/gpu/drm/i915/i915_drv.h           |  18 +-
> >  2 files changed, 187 insertions(+), 203 deletions(-)
>
Jani Nikula Sept. 7, 2021, 8:09 a.m. UTC | #3
On Fri, 03 Sep 2021, "Souza, Jose" <jose.souza@intel.com> wrote:
> On Fri, 2021-09-03 at 14:04 +0300, Jani Nikula wrote:
>> José, I'd like to get an ack from you on this before applying. I know
>> it's bound conflict with your in flight series. Thoughts?
>
> If you are okay in adding more data at the end of intel_bios_encoder_data we should be fine.
> Information from other VBT blocks will need to be added to intel_bios_encoder_data.
>
> It will badly conflict with series but any redundant byte saved is worthy.

Thanks for the review and ack, pushed.

Moving stuff from drm_i915_private to intel_bios_encoder_data will be a
nice improvement.

BR,
Jani.