| Message ID | cover.1639057801.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: include reductions | expand |
On Thu, Dec 09, 2021 at 03:50:55PM +0200, Jani Nikula wrote: > Remove some useless includes as well as ones that can be removed with > trivial changes. > > Jani Nikula (7): > drm/i915/reset: remove useless intel_display_types.h include > drm/i915/active: remove useless i915_utils.h include > drm/i915/psr: avoid intel_frontbuffer.h include with declaration > drm/i915/fbc: avoid intel_frontbuffer.h include with declaration > drm/i915/fb: reduce include dependencies > drm/i915/pxp: un-inline intel_pxp_is_enabled() > drm/i915/pxp: remove useless includes Apart from the slight display reset stuff oddness this all looks good. Series is Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > drivers/gpu/drm/i915/display/intel_fbc.h | 3 +-- > drivers/gpu/drm/i915/display/intel_frontbuffer.h | 2 +- > drivers/gpu/drm/i915/display/intel_psr.h | 11 ++++++----- > drivers/gpu/drm/i915/gt/intel_reset.c | 1 - > drivers/gpu/drm/i915/i915_active_types.h | 2 -- > drivers/gpu/drm/i915/pxp/intel_pxp.c | 5 +++++ > drivers/gpu/drm/i915/pxp/intel_pxp.h | 14 ++++++++------ > drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 2 -- > 8 files changed, 21 insertions(+), 19 deletions(-) > > -- > 2.30.2
On Fri, 10 Dec 2021, Patchwork <patchwork@emeril.freedesktop.org> wrote: > == Series Details == > > Series: drm/i915: include reductions > URL : https://patchwork.freedesktop.org/series/97789/ > State : failure > > == Summary == > > CALL scripts/checksyscalls.sh > CALL scripts/atomic/check-atomics.sh > DESCEND objtool > CHK include/generated/compile.h > CC [M] drivers/gpu/drm/i915/gem/i915_gem_create.o > In file included from drivers/gpu/drm/i915/gem/i915_gem_create.c:9: > ./drivers/gpu/drm/i915/pxp/intel_pxp.h: In function ‘intel_pxp_start’: > ./drivers/gpu/drm/i915/pxp/intel_pxp.h:45:10: error: ‘ENODEV’ undeclared (first use in this function) > return -ENODEV; > ^~~~~~ > ./drivers/gpu/drm/i915/pxp/intel_pxp.h:45:10: note: each undeclared identifier is reported only once for each function it appears in > ./drivers/gpu/drm/i915/pxp/intel_pxp.h: In function ‘intel_pxp_key_check’: > ./drivers/gpu/drm/i915/pxp/intel_pxp.h:62:10: error: ‘ENODEV’ undeclared (first use in this function) > return -ENODEV; > ^~~~~~ > scripts/Makefile.build:287: recipe for target 'drivers/gpu/drm/i915/gem/i915_gem_create.o' failed > make[4]: *** [drivers/gpu/drm/i915/gem/i915_gem_create.o] Error 1 > scripts/Makefile.build:549: recipe for target 'drivers/gpu/drm/i915' failed > make[3]: *** [drivers/gpu/drm/i915] Error 2 > scripts/Makefile.build:549: recipe for target 'drivers/gpu/drm' failed > make[2]: *** [drivers/gpu/drm] Error 2 > scripts/Makefile.build:549: recipe for target 'drivers/gpu' failed > make[1]: *** [drivers/gpu] Error 2 > Makefile:1846: recipe for target 'drivers' failed > make: *** [drivers] Error 2 I guess this means we have CONFIG_DRM_I915_PXP=n in CI. BR, Jani.