mbox series

[v2,00/12] drm/edid: cleanup and refactoring around validity checks

Message ID cover.1648752228.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/edid: cleanup and refactoring around validity checks | expand

Message

Jani Nikula March 31, 2022, 6:44 p.m. UTC
v2 of https://patchwork.freedesktop.org/series/101931/

Rebased, review comments addressed.

BR,
Jani.



Jani Nikula (12):
  drm/edid: use struct edid * in drm_do_get_edid()
  drm/edid: clean up EDID block checksum functions
  drm/edid: add edid_block_tag() helper to get the EDID extension tag
  drm/edid: make drm_edid_header_is_valid() accept void pointer
  drm/edid: clean up edid_is_zero()
  drm/edid: split out edid_header_fix()
  drm/edid: split drm_edid_block_valid() to check and act parts
  drm/edid: use a better variable name for EDID block read retries
  drm/edid: simplify block check when filtering invalid blocks
  drm/edid: split out invalid block filtering to a separate function
  drm/edid: track invalid blocks in drm_do_get_edid()
  drm/edid: reduce magic when updating the EDID block checksum

 drivers/gpu/drm/drm_edid.c | 295 +++++++++++++++++++++----------------
 include/drm/drm_edid.h     |   2 +-
 2 files changed, 173 insertions(+), 124 deletions(-)

Comments

Jani Nikula April 1, 2022, 8:55 a.m. UTC | #1
On Thu, 31 Mar 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> v2 of https://patchwork.freedesktop.org/series/101931/
>
> Rebased, review comments addressed.

Ville, care to double check patches 1 & 7 please?

Thanks,
Jani.


>
> BR,
> Jani.
>
>
>
> Jani Nikula (12):
>   drm/edid: use struct edid * in drm_do_get_edid()
>   drm/edid: clean up EDID block checksum functions
>   drm/edid: add edid_block_tag() helper to get the EDID extension tag
>   drm/edid: make drm_edid_header_is_valid() accept void pointer
>   drm/edid: clean up edid_is_zero()
>   drm/edid: split out edid_header_fix()
>   drm/edid: split drm_edid_block_valid() to check and act parts
>   drm/edid: use a better variable name for EDID block read retries
>   drm/edid: simplify block check when filtering invalid blocks
>   drm/edid: split out invalid block filtering to a separate function
>   drm/edid: track invalid blocks in drm_do_get_edid()
>   drm/edid: reduce magic when updating the EDID block checksum
>
>  drivers/gpu/drm/drm_edid.c | 295 +++++++++++++++++++++----------------
>  include/drm/drm_edid.h     |   2 +-
>  2 files changed, 173 insertions(+), 124 deletions(-)
Ville Syrjälä April 1, 2022, 2:11 p.m. UTC | #2
On Fri, Apr 01, 2022 at 11:55:21AM +0300, Jani Nikula wrote:
> On Thu, 31 Mar 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> > v2 of https://patchwork.freedesktop.org/series/101931/
> >
> > Rebased, review comments addressed.
> 
> Ville, care to double check patches 1 & 7 please?

Looks fine by me
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Thanks,
> Jani.
> 
> 
> >
> > BR,
> > Jani.
> >
> >
> >
> > Jani Nikula (12):
> >   drm/edid: use struct edid * in drm_do_get_edid()
> >   drm/edid: clean up EDID block checksum functions
> >   drm/edid: add edid_block_tag() helper to get the EDID extension tag
> >   drm/edid: make drm_edid_header_is_valid() accept void pointer
> >   drm/edid: clean up edid_is_zero()
> >   drm/edid: split out edid_header_fix()
> >   drm/edid: split drm_edid_block_valid() to check and act parts
> >   drm/edid: use a better variable name for EDID block read retries
> >   drm/edid: simplify block check when filtering invalid blocks
> >   drm/edid: split out invalid block filtering to a separate function
> >   drm/edid: track invalid blocks in drm_do_get_edid()
> >   drm/edid: reduce magic when updating the EDID block checksum
> >
> >  drivers/gpu/drm/drm_edid.c | 295 +++++++++++++++++++++----------------
> >  include/drm/drm_edid.h     |   2 +-
> >  2 files changed, 173 insertions(+), 124 deletions(-)
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
Jani Nikula April 1, 2022, 4:18 p.m. UTC | #3
On Fri, 01 Apr 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Apr 01, 2022 at 11:55:21AM +0300, Jani Nikula wrote:
>> On Thu, 31 Mar 2022, Jani Nikula <jani.nikula@intel.com> wrote:
>> > v2 of https://patchwork.freedesktop.org/series/101931/
>> >
>> > Rebased, review comments addressed.
>> 
>> Ville, care to double check patches 1 & 7 please?
>
> Looks fine by me
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed the lot to drm-misc-next.

BR,
Jani.

>
>> 
>> Thanks,
>> Jani.
>> 
>> 
>> >
>> > BR,
>> > Jani.
>> >
>> >
>> >
>> > Jani Nikula (12):
>> >   drm/edid: use struct edid * in drm_do_get_edid()
>> >   drm/edid: clean up EDID block checksum functions
>> >   drm/edid: add edid_block_tag() helper to get the EDID extension tag
>> >   drm/edid: make drm_edid_header_is_valid() accept void pointer
>> >   drm/edid: clean up edid_is_zero()
>> >   drm/edid: split out edid_header_fix()
>> >   drm/edid: split drm_edid_block_valid() to check and act parts
>> >   drm/edid: use a better variable name for EDID block read retries
>> >   drm/edid: simplify block check when filtering invalid blocks
>> >   drm/edid: split out invalid block filtering to a separate function
>> >   drm/edid: track invalid blocks in drm_do_get_edid()
>> >   drm/edid: reduce magic when updating the EDID block checksum
>> >
>> >  drivers/gpu/drm/drm_edid.c | 295 +++++++++++++++++++++----------------
>> >  include/drm/drm_edid.h     |   2 +-
>> >  2 files changed, 173 insertions(+), 124 deletions(-)
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center