| Message ID | cover.1651261886.git.ashutosh.dixit@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Media freq factor and per-gt enhancements/fixes | expand |
On Fri, 29 Apr 2022 16:38:35 -0700, Patchwork wrote: > > Possible regressions > > * igt@gem_eio@in-flight-suspend: > > * shard-skl: PASS -> INCOMPLETE This failure in unrelated. > > * {igt@i915_pm_disag_freq@media-freq@gt0} (NEW): > > * shard-iclb: NOTRUN -> SKIP > > * shard-tglb: NOTRUN -> SKIP These failures are expected, the test will skip on platforms which do not support this feature. > > * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled: > > * shard-kbl: PASS -> FAIL This failure in unrelated. > New tests > > New tests have been introduced between CI_DRM_11583_full and Patchwork_102665v4_full: > > New IGT tests (1) > > * igt@i915_pm_disag_freq@media-freq@gt0: > > * Statuses : 7 skip(s) > * Exec time: [0.0] s These skips are the same as above and expected. Thanks. -- Ashutosh
Re-reported and few comments below. -----Original Message----- From: Dixit, Ashutosh <ashutosh.dixit@intel.com> Sent: Friday, April 29, 2022 5:45 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev4) On Fri, 29 Apr 2022 16:38:35 -0700, Patchwork wrote: > > Possible regressions > > * igt@gem_eio@in-flight-suspend: > > * shard-skl: PASS -> INCOMPLETE This failure in unrelated. > > * {igt@i915_pm_disag_freq@media-freq@gt0} (NEW): > > * shard-iclb: NOTRUN -> SKIP > > * shard-tglb: NOTRUN -> SKIP These failures are expected, the test will skip on platforms which do not support this feature. Lakshmi: These tests are not in yet in CI bug log. > > * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled: > > * shard-kbl: PASS -> FAIL This failure in unrelated. Lakshmi: Filed https://gitlab.freedesktop.org/drm/intel/-/issues/5870 igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled - fail - Failed assertion: rc == 0 > New tests > > New tests have been introduced between CI_DRM_11583_full and Patchwork_102665v4_full: > > New IGT tests (1) > > * igt@i915_pm_disag_freq@media-freq@gt0: > > * Statuses : 7 skip(s) > * Exec time: [0.0] s These skips are the same as above and expected. Thanks. -- Ashutosh
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionality: * Patches 1 and 2 implement basic sysfs controls for media freq * Patch 3 extends previous pcode functions for multiple gt's and patch 4 adds a couple of pcode helpers * Patch 5 uses the new pcode functions to retrieve media RP0/RPn freq * Patch 6 fixes memory leaks in the previous per-gt sysfs implementation and some code refactoring * Patch 7 creates a gt/gtN/.defaults directory to expose default RPS parameter values in the per-gt sysfs * Patch 8 adds the default value for media_freq_factor to gt/gtN/.defaults IGT tests for this new functionality have also been posted at: https://patchwork.freedesktop.org/series/103107/ Test-with: 20220426000337.9367-1-ashutosh.dixit@intel.com v2: Fixed commit author on patches 5 and 6 (Rodrigo) Added new patch 4 v3: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo) v4: Retain previous pcode function names to eliminate needless #defines (Rodrigo) Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Andi Shyti <andi.shyti@linux.intel.com> Ashutosh Dixit (6): drm/i915: Introduce has_media_ratio_mode drm/i915/gt: Add media freq factor to per-gt sysfs drm/i915/pcode: Extend pcode functions for multiple gt's drm/i915/gt: Fix memory leaks in per-gt sysfs drm/i915/gt: Expose per-gt RPS defaults in sysfs drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs Dale B Stimson (2): drm/i915/pcode: Add a couple of pcode helpers drm/i915/gt: Add media RP0/RPn to per-gt sysfs drivers/gpu/drm/i915/display/hsw_ips.c | 4 +- drivers/gpu/drm/i915/display/intel_bw.c | 6 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 16 +- .../drm/i915/display/intel_display_power.c | 2 +- .../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 +- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 35 ++- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 12 +- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 246 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 14 + drivers/gpu/drm/i915/gt/intel_llc.c | 3 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 7 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 2 +- .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 39 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + drivers/gpu/drm/i915/i915_driver.c | 20 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/i915_reg.h | 11 + drivers/gpu/drm/i915/i915_sysfs.c | 2 + drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_dram.c | 2 +- drivers/gpu/drm/i915/intel_pcode.c | 92 ++++--- drivers/gpu/drm/i915/intel_pcode.h | 20 +- drivers/gpu/drm/i915/intel_pm.c | 10 +- 32 files changed, 473 insertions(+), 103 deletions(-)