mbox series

[v1,00/13] drm/edid: expand on struct drm_edid usage

Message ID cover.1653381821.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/edid: expand on struct drm_edid usage | expand

Message

Jani Nikula May 24, 2022, 10:39 a.m. UTC
Hey all, I'm adding a bunch of people to the cover letter, sorry for the
noise.

I've been putting a lot of effort lately into cleaning up our EDID
parsing. It's been long overdue. Here, we finally leverage all that prep
work to implement the HDMI Forum HF-EEODB extension. In short, HF-EEODB
lets an EDID extension override the number of extensions indicated in
the base block. That has a lot of implications when it comes to EDID
parsing and memory allocation that is currently spread around the
subsystem.

I've added the opaque struct drm_edid in commit e4ccf9a777d3 ("drm/edid:
add struct drm_edid container"). The commit message is worth a
read. Here, I'm expanding struct drm_edid to the interfaces for EDID
reading and parsing. They all get an overhaul, along with the probe
helper .get_modes() hook.

In my mind, there is really no alternative to centralizing the EDID
parsing, and hiding the details in drm_edid.c.

I'm also adding a TODO entry; there's still a bunch of work to be done
across the subsystem.


BR,
Jani.


Cc: Adam Jackson <ajax@redhat.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Xinhui Pan <Xinhui.Pan@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org

Jani Nikula (13):
  drm/edid: add block count and data helper functions for drm_edid
  drm/edid: keep track of alloc size in drm_do_get_edid()
  drm/edid: add new interfaces around struct drm_edid
  drm/edid: add drm_edid_connector_update()
  drm/probe-helper: abstract .get_modes() connector helper call
  drm/probe-helper: make .get_modes() optional, add default action
  drm/probe-helper: add .get_edid() callback
  drm/edid: add drm_edid_raw() to access the raw EDID data
  drm/i915/edid: convert DP, HDMI and LVDS to drm_edid
  drm/edid: do invalid block filtering in-place
  drm/edid: add HF-EEODB support to EDID read and allocation
  drm/edid: take HF-EEODB extension count into account
  drm/todo: add entry for converting the subsystem to struct drm_edid

 Documentation/gpu/todo.rst                    |  25 +
 drivers/gpu/drm/drm_connector.c               |   2 +
 drivers/gpu/drm/drm_edid.c                    | 538 ++++++++++++++++--
 drivers/gpu/drm/drm_probe_helper.c            |  48 +-
 .../gpu/drm/i915/display/intel_connector.c    |   4 +-
 .../drm/i915/display/intel_display_types.h    |   4 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  72 +--
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  26 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |  35 +-
 include/drm/drm_edid.h                        |  12 +
 include/drm/drm_modeset_helper_vtables.h      |  19 +
 11 files changed, 650 insertions(+), 135 deletions(-)

Comments

Jani Nikula May 24, 2022, 11:37 a.m. UTC | #1
On Tue, 24 May 2022, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/edid: expand on struct drm_edid usage
> URL   : https://patchwork.freedesktop.org/series/104309/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_11693 -> Patchwork_104309v1
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_104309v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_104309v1, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/index.html
>
> Participating hosts (44 -> 45)
> ------------------------------
>
>   Additional (2): fi-icl-u2 bat-dg1-5 
>   Missing    (1): fi-pnv-d510 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_104309v1:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_pm_rpm@module-reload:
>     - fi-skl-guc:         [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-skl-guc/igt@i915_pm_rpm@module-reload.html

Tomi, this link is giving me access denied.

BR,
Jani.

>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_104309v1 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@fbdev@write:
>     - bat-dg1-5:          NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@fbdev@write.html
>
>   * igt@gem_huc_copy@huc-copy:
>     - fi-icl-u2:          NOTRUN -> [SKIP][4] ([i915#2190])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - fi-icl-u2:          NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@gem_mmap@basic:
>     - bat-dg1-5:          NOTRUN -> [SKIP][6] ([i915#4083])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@gem_mmap@basic.html
>
>   * igt@gem_tiled_fence_blits@basic:
>     - bat-dg1-5:          NOTRUN -> [SKIP][7] ([i915#4077]) +2 similar issues
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@gem_tiled_fence_blits@basic.html
>
>   * igt@gem_tiled_pread_basic:
>     - bat-dg1-5:          NOTRUN -> [SKIP][8] ([i915#4079]) +1 similar issue
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@gem_tiled_pread_basic.html
>
>   * igt@i915_pm_backlight@basic-brightness:
>     - bat-dg1-5:          NOTRUN -> [SKIP][9] ([i915#1155])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
>
>   * igt@i915_pm_rpm@module-reload:
>     - fi-cfl-8109u:       [PASS][10] -> [DMESG-WARN][11] ([i915#62]) +16 similar issues
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
>
>   * igt@i915_selftest@live@hangcheck:
>     - bat-dg1-5:          NOTRUN -> [DMESG-FAIL][12] ([i915#4494] / [i915#4957])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
>     - bat-dg1-6:          [PASS][13] -> [DMESG-FAIL][14] ([i915#4494] / [i915#4957])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
>     - fi-snb-2600:        [PASS][15] -> [INCOMPLETE][16] ([i915#3921])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
>
>   * igt@i915_selftest@live@late_gt_pm:
>     - fi-bsw-nick:        [PASS][17] -> [DMESG-FAIL][18] ([i915#3428])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
>
>   * igt@i915_suspend@basic-s2idle-without-i915:
>     - bat-dg1-5:          NOTRUN -> [INCOMPLETE][19] ([i915#6011])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@i915_suspend@basic-s2idle-without-i915.html
>
>   * igt@i915_suspend@basic-s3-without-i915:
>     - fi-icl-u2:          NOTRUN -> [SKIP][20] ([i915#5903])
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@i915_suspend@basic-s3-without-i915.html
>
>   * igt@kms_addfb_basic@basic-y-tiled-legacy:
>     - bat-dg1-5:          NOTRUN -> [SKIP][21] ([i915#4215])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>
>   * igt@kms_addfb_basic@tile-pitch-mismatch:
>     - bat-dg1-5:          NOTRUN -> [SKIP][22] ([i915#4212]) +7 similar issues
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_addfb_basic@tile-pitch-mismatch.html
>
>   * igt@kms_busy@basic:
>     - bat-dg1-5:          NOTRUN -> [SKIP][23] ([i915#4303])
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_busy@basic.html
>
>   * igt@kms_chamelium@common-hpd-after-suspend:
>     - fi-blb-e6850:       NOTRUN -> [SKIP][24] ([fdo#109271])
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-blb-e6850/igt@kms_chamelium@common-hpd-after-suspend.html
>
>   * igt@kms_chamelium@hdmi-hpd-fast:
>     - fi-icl-u2:          NOTRUN -> [SKIP][25] ([fdo#111827]) +8 similar issues
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
>     - bat-dg1-5:          NOTRUN -> [SKIP][26] ([fdo#111827]) +7 similar issues
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>     - fi-icl-u2:          NOTRUN -> [SKIP][27] ([fdo#109278]) +2 similar issues
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>     - bat-dg1-5:          NOTRUN -> [SKIP][28] ([i915#4103] / [i915#4213]) +1 similar issue
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>
>   * igt@kms_flip@basic-flip-vs-dpms:
>     - bat-dg1-5:          NOTRUN -> [SKIP][29] ([i915#4078]) +21 similar issues
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_flip@basic-flip-vs-dpms.html
>
>   * igt@kms_flip@basic-flip-vs-modeset@b-edp1:
>     - bat-adlp-4:         [PASS][30] -> [DMESG-WARN][31] ([i915#3576])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
>
>   * igt@kms_force_connector_basic@force-load-detect:
>     - bat-dg1-5:          NOTRUN -> [SKIP][32] ([fdo#109285])
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
>     - fi-icl-u2:          NOTRUN -> [SKIP][33] ([fdo#109285])
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
>
>   * igt@kms_psr@primary_page_flip:
>     - bat-dg1-5:          NOTRUN -> [SKIP][34] ([i915#1072] / [i915#4078]) +3 similar issues
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html
>
>   * igt@kms_setmode@basic-clone-single-crtc:
>     - fi-icl-u2:          NOTRUN -> [SKIP][35] ([i915#3555])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-dg1-5:          NOTRUN -> [SKIP][36] ([i915#3555])
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
>
>   * igt@prime_vgem@basic-fence-mmap:
>     - bat-dg1-5:          NOTRUN -> [SKIP][37] ([i915#3708] / [i915#4077]) +1 similar issue
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@prime_vgem@basic-fence-mmap.html
>
>   * igt@prime_vgem@basic-userptr:
>     - fi-icl-u2:          NOTRUN -> [SKIP][38] ([i915#3301])
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-u2/igt@prime_vgem@basic-userptr.html
>     - bat-dg1-5:          NOTRUN -> [SKIP][39] ([i915#3708] / [i915#4873])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@prime_vgem@basic-userptr.html
>
>   * igt@prime_vgem@basic-write:
>     - bat-dg1-5:          NOTRUN -> [SKIP][40] ([i915#3708]) +3 similar issues
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@prime_vgem@basic-write.html
>
>   * igt@runner@aborted:
>     - bat-dg1-5:          NOTRUN -> [FAIL][41] ([i915#4312] / [i915#5257])
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-dg1-5/igt@runner@aborted.html
>     - fi-bsw-nick:        NOTRUN -> [FAIL][42] ([fdo#109271] / [i915#3428] / [i915#4312])
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-bsw-nick/igt@runner@aborted.html
>
>   
> #### Possible fixes ####
>
>   * igt@i915_selftest@live@requests:
>     - fi-blb-e6850:       [DMESG-FAIL][43] ([i915#4528]) -> [PASS][44]
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-blb-e6850/igt@i915_selftest@live@requests.html
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
>
>   * igt@kms_flip@basic-plain-flip@a-edp1:
>     - bat-adlp-4:         [DMESG-WARN][45] ([i915#3576]) -> [PASS][46] +2 similar issues
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/bat-adlp-4/igt@kms_flip@basic-plain-flip@a-edp1.html
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-adlp-4/igt@kms_flip@basic-plain-flip@a-edp1.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
>   [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
>   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>   [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
>   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>   [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
>   [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
>   [i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
>   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>   [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
>   [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
>   [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
>   [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
>   [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
>   [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
>   [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
>   [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
>   [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
>   [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
>   [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
>   [i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
>   [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
>   [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
>   [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
>   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>   [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
>   [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
>   [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
>   [i915#5356]: https://gitlab.freedesktop.org/drm/intel/issues/5356
>   [i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
>   [i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
>   [i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_11693 -> Patchwork_104309v1
>
>   CI-20190529: 20190529
>   CI_DRM_11693: 14289bc81309b2126f4ba9f339837dacf34ddf9c @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_6485: 51663917b40d36086cc1c555ce4f67b22937694d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_104309v1: 14289bc81309b2126f4ba9f339837dacf34ddf9c @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> ### Linux commits
>
> 405f61faeeda drm/todo: add entry for converting the subsystem to struct drm_edid
> c681cc2aaf5a drm/edid: take HF-EEODB extension count into account
> f055cb8a1ecd drm/edid: add HF-EEODB support to EDID read and allocation
> af8177c60fa9 drm/edid: do invalid block filtering in-place
> 4ff3b4c602da drm/i915/edid: convert DP, HDMI and LVDS to drm_edid
> 67286814782f drm/edid: add drm_edid_raw() to access the raw EDID data
> cc62659b9175 drm/probe-helper: add .get_edid() callback
> 093174764385 drm/probe-helper: make .get_modes() optional, add default action
> 42fe37d2b754 drm/probe-helper: abstract .get_modes() connector helper call
> 86541a011dae drm/edid: add drm_edid_connector_update()
> 336362b1c7de drm/edid: add new interfaces around struct drm_edid
> fc34398be5a0 drm/edid: keep track of alloc size in drm_do_get_edid()
> 239e9dcf8e3a drm/edid: add block count and data helper functions for drm_edid
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/index.html
Sarvela, Tomi P May 24, 2022, 11:41 a.m. UTC | #2
> From: Nikula, Jani <jani.nikula@intel.com>
> 
> On Tue, 24 May 2022, Patchwork <patchwork@emeril.freedesktop.org>
> wrote:
> > == Series Details ==
> >
> > Series: drm/edid: expand on struct drm_edid usage
> > URL   : https://patchwork.freedesktop.org/series/104309/
> > State : failure
> >
> > == Summary ==
> >
> >
> > #### Possible regressions ####
> >
> >   * igt@i915_pm_rpm@module-reload:
> >     - fi-skl-guc:         [PASS][1] -> [FAIL][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-skl-
> guc/igt@i915_pm_rpm@module-reload.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-skl-
> guc/igt@i915_pm_rpm@module-reload.html
> 
> Tomi, this link is giving me access denied.

Both links work. Patchwork posting is done before results are synced to
upstream service. This is noticeable with 404 if the transfer is slow.
The issue is known and will be fixed when priorities allow.

Tomi

> >
> >
> > Known issues
> > ------------
> >
> >   Here are the changes found in Patchwork_104309v1 that come from
> known issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> >   * igt@fbdev@write:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@fbdev@write.html
> >
> >   * igt@gem_huc_copy@huc-copy:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][4] ([i915#2190])
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@gem_huc_copy@huc-copy.html
> >
> >   * igt@gem_lmem_swapping@parallel-random-engines:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@gem_lmem_swapping@parallel-random-engines.html
> >
> >   * igt@gem_mmap@basic:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][6] ([i915#4083])
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@gem_mmap@basic.html
> >
> >   * igt@gem_tiled_fence_blits@basic:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][7] ([i915#4077]) +2 similar issues
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@gem_tiled_fence_blits@basic.html
> >
> >   * igt@gem_tiled_pread_basic:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][8] ([i915#4079]) +1 similar issue
> >    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@gem_tiled_pread_basic.html
> >
> >   * igt@i915_pm_backlight@basic-brightness:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][9] ([i915#1155])
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@i915_pm_backlight@basic-brightness.html
> >
> >   * igt@i915_pm_rpm@module-reload:
> >     - fi-cfl-8109u:       [PASS][10] -> [DMESG-WARN][11] ([i915#62]) +16 similar
> issues
> >    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-cfl-
> 8109u/igt@i915_pm_rpm@module-reload.html
> >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-cfl-
> 8109u/igt@i915_pm_rpm@module-reload.html
> >
> >   * igt@i915_selftest@live@hangcheck:
> >     - bat-dg1-5:          NOTRUN -> [DMESG-FAIL][12] ([i915#4494] /
> [i915#4957])
> >    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@i915_selftest@live@hangcheck.html
> >     - bat-dg1-6:          [PASS][13] -> [DMESG-FAIL][14] ([i915#4494] /
> [i915#4957])
> >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/bat-dg1-
> 6/igt@i915_selftest@live@hangcheck.html
> >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-6/igt@i915_selftest@live@hangcheck.html
> >     - fi-snb-2600:        [PASS][15] -> [INCOMPLETE][16] ([i915#3921])
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-snb-
> 2600/igt@i915_selftest@live@hangcheck.html
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-
> snb-2600/igt@i915_selftest@live@hangcheck.html
> >
> >   * igt@i915_selftest@live@late_gt_pm:
> >     - fi-bsw-nick:        [PASS][17] -> [DMESG-FAIL][18] ([i915#3428])
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-bsw-
> nick/igt@i915_selftest@live@late_gt_pm.html
> >    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-
> bsw-nick/igt@i915_selftest@live@late_gt_pm.html
> >
> >   * igt@i915_suspend@basic-s2idle-without-i915:
> >     - bat-dg1-5:          NOTRUN -> [INCOMPLETE][19] ([i915#6011])
> >    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@i915_suspend@basic-s2idle-without-i915.html
> >
> >   * igt@i915_suspend@basic-s3-without-i915:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][20] ([i915#5903])
> >    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@i915_suspend@basic-s3-without-i915.html
> >
> >   * igt@kms_addfb_basic@basic-y-tiled-legacy:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][21] ([i915#4215])
> >    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
> >
> >   * igt@kms_addfb_basic@tile-pitch-mismatch:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][22] ([i915#4212]) +7 similar issues
> >    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_addfb_basic@tile-pitch-mismatch.html
> >
> >   * igt@kms_busy@basic:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][23] ([i915#4303])
> >    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_busy@basic.html
> >
> >   * igt@kms_chamelium@common-hpd-after-suspend:
> >     - fi-blb-e6850:       NOTRUN -> [SKIP][24] ([fdo#109271])
> >    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-blb-
> e6850/igt@kms_chamelium@common-hpd-after-suspend.html
> >
> >   * igt@kms_chamelium@hdmi-hpd-fast:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][25] ([fdo#111827]) +8 similar issues
> >    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@kms_chamelium@hdmi-hpd-fast.html
> >     - bat-dg1-5:          NOTRUN -> [SKIP][26] ([fdo#111827]) +7 similar issues
> >    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_chamelium@hdmi-hpd-fast.html
> >
> >   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][27] ([fdo#109278]) +2 similar issues
> >    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
> >     - bat-dg1-5:          NOTRUN -> [SKIP][28] ([i915#4103] / [i915#4213]) +1
> similar issue
> >    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
> >
> >   * igt@kms_flip@basic-flip-vs-dpms:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][29] ([i915#4078]) +21 similar issues
> >    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_flip@basic-flip-vs-dpms.html
> >
> >   * igt@kms_flip@basic-flip-vs-modeset@b-edp1:
> >     - bat-adlp-4:         [PASS][30] -> [DMESG-WARN][31] ([i915#3576])
> >    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/bat-adlp-
> 4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
> >    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
> >
> >   * igt@kms_force_connector_basic@force-load-detect:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][32] ([fdo#109285])
> >    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_force_connector_basic@force-load-detect.html
> >     - fi-icl-u2:          NOTRUN -> [SKIP][33] ([fdo#109285])
> >    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@kms_force_connector_basic@force-load-detect.html
> >
> >   * igt@kms_psr@primary_page_flip:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][34] ([i915#1072] / [i915#4078]) +3
> similar issues
> >    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_psr@primary_page_flip.html
> >
> >   * igt@kms_setmode@basic-clone-single-crtc:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][35] ([i915#3555])
> >    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@kms_setmode@basic-clone-single-crtc.html
> >     - bat-dg1-5:          NOTRUN -> [SKIP][36] ([i915#3555])
> >    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@kms_setmode@basic-clone-single-crtc.html
> >
> >   * igt@prime_vgem@basic-fence-mmap:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][37] ([i915#3708] / [i915#4077]) +1
> similar issue
> >    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@prime_vgem@basic-fence-mmap.html
> >
> >   * igt@prime_vgem@basic-userptr:
> >     - fi-icl-u2:          NOTRUN -> [SKIP][38] ([i915#3301])
> >    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-icl-
> u2/igt@prime_vgem@basic-userptr.html
> >     - bat-dg1-5:          NOTRUN -> [SKIP][39] ([i915#3708] / [i915#4873])
> >    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@prime_vgem@basic-userptr.html
> >
> >   * igt@prime_vgem@basic-write:
> >     - bat-dg1-5:          NOTRUN -> [SKIP][40] ([i915#3708]) +3 similar issues
> >    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@prime_vgem@basic-write.html
> >
> >   * igt@runner@aborted:
> >     - bat-dg1-5:          NOTRUN -> [FAIL][41] ([i915#4312] / [i915#5257])
> >    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> dg1-5/igt@runner@aborted.html
> >     - fi-bsw-nick:        NOTRUN -> [FAIL][42] ([fdo#109271] / [i915#3428] /
> [i915#4312])
> >    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-
> bsw-nick/igt@runner@aborted.html
> >
> >
> > #### Possible fixes ####
> >
> >   * igt@i915_selftest@live@requests:
> >     - fi-blb-e6850:       [DMESG-FAIL][43] ([i915#4528]) -> [PASS][44]
> >    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/fi-blb-
> e6850/igt@i915_selftest@live@requests.html
> >    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/fi-blb-
> e6850/igt@i915_selftest@live@requests.html
> >
> >   * igt@kms_flip@basic-plain-flip@a-edp1:
> >     - bat-adlp-4:         [DMESG-WARN][45] ([i915#3576]) -> [PASS][46] +2
> similar issues
> >    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11693/bat-adlp-
> 4/igt@kms_flip@basic-plain-flip@a-edp1.html
> >    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104309v1/bat-
> adlp-4/igt@kms_flip@basic-plain-flip@a-edp1.html
> >
> >
> >   {name}: This element is suppressed. This means it is ignored when
> computing
> >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> >   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
> >   [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
> >   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
> >   [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
> >   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
> >   [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
> >   [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
> >   [i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
> >   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
> >   [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
> >   [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
> >   [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
> >   [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
> >   [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
> >   [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
> >   [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
> >   [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
> >   [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
> >   [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
> >   [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
> >   [i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
> >   [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
> >   [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
> >   [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
> >   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
> >   [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
> >   [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
> >   [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
> >   [i915#5356]: https://gitlab.freedesktop.org/drm/intel/issues/5356
> >   [i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
> >   [i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
> >   [i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
> >   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
> >
> >
> > Build changes
> > -------------
> >
> >   * Linux: CI_DRM_11693 -> Patchwork_104309v1
> >
> >   CI-20190529: 20190529
> >   CI_DRM_11693: 14289bc81309b2126f4ba9f339837dacf34ddf9c @
> git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_6485: 51663917b40d36086cc1c555ce4f67b22937694d @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> >   Patchwork_104309v1: 14289bc81309b2126f4ba9f339837dacf34ddf9c @
> git://anongit.freedesktop.org/gfx-ci/linux
> >
> >
> > ### Linux commits
> >
> > 405f61faeeda drm/todo: add entry for converting the subsystem to struct
> drm_edid
> > c681cc2aaf5a drm/edid: take HF-EEODB extension count into account
> > f055cb8a1ecd drm/edid: add HF-EEODB support to EDID read and allocation
> > af8177c60fa9 drm/edid: do invalid block filtering in-place
> > 4ff3b4c602da drm/i915/edid: convert DP, HDMI and LVDS to drm_edid
> > 67286814782f drm/edid: add drm_edid_raw() to access the raw EDID data
> > cc62659b9175 drm/probe-helper: add .get_edid() callback
> > 093174764385 drm/probe-helper: make .get_modes() optional, add default
> action
> > 42fe37d2b754 drm/probe-helper: abstract .get_modes() connector helper
> call
> > 86541a011dae drm/edid: add drm_edid_connector_update()
> > 336362b1c7de drm/edid: add new interfaces around struct drm_edid
> > fc34398be5a0 drm/edid: keep track of alloc size in drm_do_get_edid()
> > 239e9dcf8e3a drm/edid: add block count and data helper functions for
> drm_edid
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_104309v1/index.html
> 
> --
> Jani Nikula, Intel Open Source Graphics Center
Jani Nikula May 25, 2022, 8:48 a.m. UTC | #3
On Tue, 24 May 2022, "Sarvela, Tomi P" <tomi.p.sarvela@intel.com> wrote:
> Both links work. Patchwork posting is done before results are synced to
> upstream service. This is noticeable with 404 if the transfer is slow.
> The issue is known and will be fixed when priorities allow.

Right, I was just being impatient hitting reload. Thanks for the
explanation, again.

BR,
Jani.