| Message ID | cover.1709843865.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: debug logging improvements | expand |
On Thu, 07 Mar 2024, Jani Nikula <jani.nikula@intel.com> wrote: > Switch a handful of places over to drm device based logging and WARNs, > unify connector and crtc logging, etc. Ping for review, please. :) > > Jani Nikula (6): > drm/modes: add drm_mode_print() to dump mode in drm_printer > drm/probe-helper: switch to drm device based logging > drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer > drm/modes: switch to drm device based error logging > drm/sysfs: switch to drm device based logging > drm/client: switch to drm device based logging, and more > > drivers/gpu/drm/drm_client_modeset.c | 129 +++++++++++++++------------ > drivers/gpu/drm/drm_modes.c | 51 +++++++---- > drivers/gpu/drm/drm_probe_helper.c | 41 ++++----- > drivers/gpu/drm/drm_sysfs.c | 21 +++-- > include/drm/drm_modes.h | 2 + > 5 files changed, 137 insertions(+), 107 deletions(-)
Hi, with your Oops on [5/6] fixed and my comment on [1/6] considered: Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards Thomas Am 07.03.24 um 21:39 schrieb Jani Nikula: > Switch a handful of places over to drm device based logging and WARNs, > unify connector and crtc logging, etc. > > Jani Nikula (6): > drm/modes: add drm_mode_print() to dump mode in drm_printer > drm/probe-helper: switch to drm device based logging > drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer > drm/modes: switch to drm device based error logging > drm/sysfs: switch to drm device based logging > drm/client: switch to drm device based logging, and more > > drivers/gpu/drm/drm_client_modeset.c | 129 +++++++++++++++------------ > drivers/gpu/drm/drm_modes.c | 51 +++++++---- > drivers/gpu/drm/drm_probe_helper.c | 41 ++++----- > drivers/gpu/drm/drm_sysfs.c | 21 +++-- > include/drm/drm_modes.h | 2 + > 5 files changed, 137 insertions(+), 107 deletions(-) >
On Fri, 05 Apr 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote: > Hi, > > with your Oops on [5/6] fixed and my comment on [1/6] considered: > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Thanks! I ended up dropping a couple of patches based on Ville's comment about mode logging, and added a few more in v2. I tried to preserve your R-b where I think I didn't change much or nothing at all. BR, Jani. > > Best regards > Thomas > > > Am 07.03.24 um 21:39 schrieb Jani Nikula: >> Switch a handful of places over to drm device based logging and WARNs, >> unify connector and crtc logging, etc. >> >> Jani Nikula (6): >> drm/modes: add drm_mode_print() to dump mode in drm_printer >> drm/probe-helper: switch to drm device based logging >> drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer >> drm/modes: switch to drm device based error logging >> drm/sysfs: switch to drm device based logging >> drm/client: switch to drm device based logging, and more >> >> drivers/gpu/drm/drm_client_modeset.c | 129 +++++++++++++++------------ >> drivers/gpu/drm/drm_modes.c | 51 +++++++---- >> drivers/gpu/drm/drm_probe_helper.c | 41 ++++----- >> drivers/gpu/drm/drm_sysfs.c | 21 +++-- >> include/drm/drm_modes.h | 2 + >> 5 files changed, 137 insertions(+), 107 deletions(-) >>