mbox series

[v3,00/16] drm/i915/dp: 128b/132b uncompressed SST

Message ID cover.1735912293.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/dp: 128b/132b uncompressed SST | expand

Message

Jani Nikula Jan. 3, 2025, 1:52 p.m. UTC
This is v4 of [1], enabling uncompressed 128b/132b UHBR SST.

Address review comments from Imre.

[1] https://lore.kernel.org/r/cover.1734643485.git.jani.nikula@intel.com

Jani Nikula (16):
  drm/mst: remove mgr parameter and debug logging from
    drm_dp_get_vc_payload_bw()
  drm/i915/mst: drop connector parameter from intel_dp_mst_bw_overhead()
  drm/i915/mst: drop connector parameter from intel_dp_mst_compute_m_n()
  drm/i915/mst: change return value of
    mst_stream_find_vcpi_slots_for_bpp()
  drm/i915/mst: remove crtc_state->pbn
  drm/i915/mst: split out a helper for figuring out the TU
  drm/i915/mst: adapt intel_dp_mtp_tu_compute_config() for 128b/132b SST
  drm/i915/ddi: enable 128b/132b TRANS_DDI_FUNC_CTL mode for UHBR SST
  drm/i915/ddi: 128b/132b SST also needs DP_TP_CTL_MODE_MST
  drm/i915/ddi: write payload for 128b/132b SST
  drm/i915/ddi: initialize 128b/132b SST DP2 VFREQ registers
  drm/i915/ddi: enable ACT handling for 128b/132b SST
  drm/i915/ddi: start distinguishing 128b/132b SST and MST at state
    readout
  drm/i915/ddi: handle 128b/132b SST in intel_ddi_read_func_ctl()
  drm/i915/ddi: disable trancoder port select for 128b/132b SST
  drm/i915/dp: compute config for 128b/132b SST w/o DSC

 drivers/gpu/drm/display/drm_dp_mst_topology.c |  10 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 122 ++++++++--
 .../drm/i915/display/intel_display_types.h    |   2 -
 drivers/gpu/drm/i915/display/intel_dp.c       |  34 ++-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   | 218 +++++++++---------
 drivers/gpu/drm/i915/display/intel_dp_mst.h   |   7 +
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |   3 +-
 .../gpu/drm/tests/drm_dp_mst_helper_test.c    |  17 +-
 include/drm/display/drm_dp_mst_helper.h       |   3 +-
 9 files changed, 259 insertions(+), 157 deletions(-)

Comments

Jani Nikula Jan. 7, 2025, 5:05 p.m. UTC | #1
On Fri, 03 Jan 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> This is v4 of [1], enabling uncompressed 128b/132b UHBR SST.
>
> Address review comments from Imre.

Thanks for the review, pushed to drm-intel-next.

BR,
Jani.

>
> [1] https://lore.kernel.org/r/cover.1734643485.git.jani.nikula@intel.com
>
> Jani Nikula (16):
>   drm/mst: remove mgr parameter and debug logging from
>     drm_dp_get_vc_payload_bw()
>   drm/i915/mst: drop connector parameter from intel_dp_mst_bw_overhead()
>   drm/i915/mst: drop connector parameter from intel_dp_mst_compute_m_n()
>   drm/i915/mst: change return value of
>     mst_stream_find_vcpi_slots_for_bpp()
>   drm/i915/mst: remove crtc_state->pbn
>   drm/i915/mst: split out a helper for figuring out the TU
>   drm/i915/mst: adapt intel_dp_mtp_tu_compute_config() for 128b/132b SST
>   drm/i915/ddi: enable 128b/132b TRANS_DDI_FUNC_CTL mode for UHBR SST
>   drm/i915/ddi: 128b/132b SST also needs DP_TP_CTL_MODE_MST
>   drm/i915/ddi: write payload for 128b/132b SST
>   drm/i915/ddi: initialize 128b/132b SST DP2 VFREQ registers
>   drm/i915/ddi: enable ACT handling for 128b/132b SST
>   drm/i915/ddi: start distinguishing 128b/132b SST and MST at state
>     readout
>   drm/i915/ddi: handle 128b/132b SST in intel_ddi_read_func_ctl()
>   drm/i915/ddi: disable trancoder port select for 128b/132b SST
>   drm/i915/dp: compute config for 128b/132b SST w/o DSC
>
>  drivers/gpu/drm/display/drm_dp_mst_topology.c |  10 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 122 ++++++++--
>  .../drm/i915/display/intel_display_types.h    |   2 -
>  drivers/gpu/drm/i915/display/intel_dp.c       |  34 ++-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   | 218 +++++++++---------
>  drivers/gpu/drm/i915/display/intel_dp_mst.h   |   7 +
>  drivers/gpu/drm/nouveau/dispnv50/disp.c       |   3 +-
>  .../gpu/drm/tests/drm_dp_mst_helper_test.c    |  17 +-
>  include/drm/display/drm_dp_mst_helper.h       |   3 +-
>  9 files changed, 259 insertions(+), 157 deletions(-)