Message ID | 07EEC142D30DAC40BA4DD9C0F9EE5109405B7767@FMSMSX107.amr.corp.intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Jul 02, 2014 at 04:36:51PM +0000, Reese, Armin C wrote: > Hi Daniel, > > Is it possible to get this patch on the review board? I've been on > vacation a couple of weeks and haven't been around to push it. Already done the review in my other reply ... Have you missed it? http://www.spinics.net/lists/intel-gfx/msg47146.html -Daniel > > Thanks, > Armin > > -----Original Message----- > From: Reese, Armin C > Sent: Thursday, June 12, 2014 2:19 PM > To: intel-gfx@lists.freedesktop.org > Cc: Reese, Armin C > Subject: [PATCH] igt/gem_partial_pwrite_pread: Add set-cache subtest to validate JIRA VIZ-3721 > > From: Armin Reese <armin.c.reese@intel.com> > > This subtest forces the driver down the code path in i915_gem_object_set_cache_level() which unbinds VMAs and triggers the kernel panic described in VIZ-3721. This test will pass if the bug fix is in place. > > Bugzilla: https://bugs.fredesktop.org/show_bug.cgi?id=76384 > Signed-off-by: Armin Reese <armin.c.reese@intel.com> > --- > tests/gem_partial_pwrite_pread.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/gem_partial_pwrite_pread.c b/tests/gem_partial_pwrite_pread.c > index 7945ba7..3e3ecc9 100644 > --- a/tests/gem_partial_pwrite_pread.c > +++ b/tests/gem_partial_pwrite_pread.c > @@ -131,6 +131,14 @@ static void test_partial_reads(void) > > } > > +static void test_set_cache(void) > +{ > + igt_info("checking set-cache\n"); > + > + blt_bo_fill(staging_bo, scratch_bo, 0); > + > +} > + > static void test_partial_writes(void) > { > int i, j; > @@ -244,6 +252,9 @@ static void do_tests(int cache_level, const char *suffix) > gem_set_caching(fd, scratch_bo->handle, cache_level); > } > > + igt_subtest_f("set-cache%s", suffix) > + test_set_cache(); > + > igt_subtest_f("reads%s", suffix) > test_partial_reads(); > > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/tests/gem_partial_pwrite_pread.c b/tests/gem_partial_pwrite_pread.c index 7945ba7..3e3ecc9 100644 --- a/tests/gem_partial_pwrite_pread.c +++ b/tests/gem_partial_pwrite_pread.c @@ -131,6 +131,14 @@ static void test_partial_reads(void) } +static void test_set_cache(void) +{ + igt_info("checking set-cache\n"); + + blt_bo_fill(staging_bo, scratch_bo, 0); + +} + static void test_partial_writes(void) { int i, j; @@ -244,6 +252,9 @@ static void do_tests(int cache_level, const char *suffix) gem_set_caching(fd, scratch_bo->handle, cache_level); } + igt_subtest_f("set-cache%s", suffix) + test_set_cache(); + igt_subtest_f("reads%s", suffix) test_partial_reads();