| Message ID | 11db9a1438142d413ad228e6d1953463dfbb9236.1559562608.git.guillaume.tucker@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [i-g-t,1/4] tests: add libatomic dependency | expand |
On Mon, Jun 03, 2019 at 12:54:48PM +0100, Guillaume Tucker wrote: > Add libatomic to the Fedora docker image so it can link binaries that > use __atomic_* functions. > > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> > --- > Dockerfile.fedora | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Dockerfile.fedora b/Dockerfile.fedora > index 6686e587613d..c84b412b0723 100644 > --- a/Dockerfile.fedora > +++ b/Dockerfile.fedora > @@ -1,7 +1,7 @@ > FROM fedora:30 > > RUN dnf install -y \ > - gcc flex bison meson ninja-build xdotool \ > + gcc flex bison libatomic meson ninja-build xdotool \ > 'pkgconfig(libdrm)' \ > 'pkgconfig(pciaccess)' \ > 'pkgconfig(libkmod)' \ Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> I wonder how does the libatomic gets installed implicitly in Debian.
On Thu, 2019-06-06 at 10:21 +0300, Arkadiusz Hiler wrote: > On Mon, Jun 03, 2019 at 12:54:48PM +0100, Guillaume Tucker wrote: > > Add libatomic to the Fedora docker image so it can link binaries that > > use __atomic_* functions. > > > > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> > > --- > > Dockerfile.fedora | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Dockerfile.fedora b/Dockerfile.fedora > > index 6686e587613d..c84b412b0723 100644 > > --- a/Dockerfile.fedora > > +++ b/Dockerfile.fedora > > @@ -1,7 +1,7 @@ > > FROM fedora:30 > > > > RUN dnf install -y \ > > - gcc flex bison meson ninja-build xdotool \ > > + gcc flex bison libatomic meson ninja-build xdotool \ > > 'pkgconfig(libdrm)' \ > > 'pkgconfig(pciaccess)' \ > > 'pkgconfig(libkmod)' \ > > Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > > I wonder how does the libatomic gets installed implicitly in Debian. It's a dependency of GCC. Probably a good idea to add it anyway? > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev
On 06/06/2019 08:26, Ser, Simon wrote: > On Thu, 2019-06-06 at 10:21 +0300, Arkadiusz Hiler wrote: >> On Mon, Jun 03, 2019 at 12:54:48PM +0100, Guillaume Tucker wrote: >>> Add libatomic to the Fedora docker image so it can link binaries that >>> use __atomic_* functions. >>> >>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> >>> --- >>> Dockerfile.fedora | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Dockerfile.fedora b/Dockerfile.fedora >>> index 6686e587613d..c84b412b0723 100644 >>> --- a/Dockerfile.fedora >>> +++ b/Dockerfile.fedora >>> @@ -1,7 +1,7 @@ >>> FROM fedora:30 >>> >>> RUN dnf install -y \ >>> - gcc flex bison meson ninja-build xdotool \ >>> + gcc flex bison libatomic meson ninja-build xdotool \ >>> 'pkgconfig(libdrm)' \ >>> 'pkgconfig(pciaccess)' \ >>> 'pkgconfig(libkmod)' \ >> >> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> >> >> I wonder how does the libatomic gets installed implicitly in Debian. > > It's a dependency of GCC. Probably a good idea to add it anyway? Fair enough, I'm adding it in the v2. Guillaume
diff --git a/Dockerfile.fedora b/Dockerfile.fedora index 6686e587613d..c84b412b0723 100644 --- a/Dockerfile.fedora +++ b/Dockerfile.fedora @@ -1,7 +1,7 @@ FROM fedora:30 RUN dnf install -y \ - gcc flex bison meson ninja-build xdotool \ + gcc flex bison libatomic meson ninja-build xdotool \ 'pkgconfig(libdrm)' \ 'pkgconfig(pciaccess)' \ 'pkgconfig(libkmod)' \
Add libatomic to the Fedora docker image so it can link binaries that use __atomic_* functions. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com> --- Dockerfile.fedora | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)