diff mbox

tests: Fix duplicate 'kms_flip_event_leak' entry in tests/Makefile.sources

Message ID 1303157766-11152-1-git-send-email-shuang.he@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shuang He April 18, 2011, 8:16 p.m. UTC
Or, it will cause piglit failure to run I-G-T test case

Signed-off-by: Shuang He <shuang.he@intel.com>
---
 tests/Makefile.sources | 1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Vetter April 8, 2015, 8:14 a.m. UTC | #1
On Tue, Apr 19, 2011 at 04:16:06AM +0800, Shuang He wrote:
> Or, it will cause piglit failure to run I-G-T test case
> 
> Signed-off-by: Shuang He <shuang.he@intel.com>

How does it fail? And please fix the time on your machine, date on the
mail is 2011 ;-)
-Daniel

> ---
>  tests/Makefile.sources | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 3e3aa57..aded08f 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -85,7 +85,6 @@ TESTS_progs_M = \
>  	kms_flip \
>  	kms_flip_event_leak \
>  	kms_flip_tiling \
> -	kms_flip_event_leak \
>  	kms_mmio_vs_cs_flip \
>  	kms_pipe_b_c_ivb \
>  	kms_pipe_crc_basic \
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Shuang He April 8, 2015, 8:16 a.m. UTC | #2
> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Wednesday, April 8, 2015 4:15 PM
> To: He, Shuang
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak'
> entry in tests/Makefile.sources
> 
> On Tue, Apr 19, 2011 at 04:16:06AM +0800, Shuang He wrote:
> > Or, it will cause piglit failure to run I-G-T test case
> >
> > Signed-off-by: Shuang He <shuang.he@intel.com>
> 
> How does it fail? And please fix the time on your machine, date on the
> mail is 2011 ;-)
[He, Shuang]  Piglit is now checking duplicate case name. and duplicate 'kms_flip_event_leak' in I-G-T will directly lead piglit abort testing from start. Following are output of it:
./piglit-run.py -d tests/igt.py t
Error: A test has already been asigned the name: igt@kms_flip_event_leak
and both tests are the same.

Thanks
	--Shuang
> -Daniel
> 
> > ---
> >  tests/Makefile.sources | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> > index 3e3aa57..aded08f 100644
> > --- a/tests/Makefile.sources
> > +++ b/tests/Makefile.sources
> > @@ -85,7 +85,6 @@ TESTS_progs_M = \
> >  	kms_flip \
> >  	kms_flip_event_leak \
> >  	kms_flip_tiling \
> > -	kms_flip_event_leak \
> >  	kms_mmio_vs_cs_flip \
> >  	kms_pipe_b_c_ivb \
> >  	kms_pipe_crc_basic \
> > --
> > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
Shuang He April 9, 2015, 1:04 a.m. UTC | #3
> -----Original Message-----
> From: He, Shuang
> Sent: Wednesday, April 8, 2015 4:16 PM
> To: Daniel Vetter
> Cc: intel-gfx@lists.freedesktop.org
> Subject: RE: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak'
> entry in tests/Makefile.sources
> 
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> > Vetter
> > Sent: Wednesday, April 8, 2015 4:15 PM
> > To: He, Shuang
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak'
> > entry in tests/Makefile.sources
> >
> > On Tue, Apr 19, 2011 at 04:16:06AM +0800, Shuang He wrote:
> > > Or, it will cause piglit failure to run I-G-T test case
> > >
> > > Signed-off-by: Shuang He <shuang.he@intel.com>
> >
> > How does it fail? And please fix the time on your machine, date on the
> > mail is 2011 ;-)
> [He, Shuang]  Piglit is now checking duplicate case name. and duplicate
> 'kms_flip_event_leak' in I-G-T will directly lead piglit abort testing from start.
> Following are output of it:
> ./piglit-run.py -d tests/igt.py t
> Error: A test has already been asigned the name: igt@kms_flip_event_leak
> and both tests are the same.
[He, Shuang] Could anyone follow up this one? It's blocking our testing, though we could kind of work around it.

Thanks
	--Shuang

> 
> Thanks
> 	--Shuang
> > -Daniel
> >
> > > ---
> > >  tests/Makefile.sources | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> > > index 3e3aa57..aded08f 100644
> > > --- a/tests/Makefile.sources
> > > +++ b/tests/Makefile.sources
> > > @@ -85,7 +85,6 @@ TESTS_progs_M = \
> > >  	kms_flip \
> > >  	kms_flip_event_leak \
> > >  	kms_flip_tiling \
> > > -	kms_flip_event_leak \
> > >  	kms_mmio_vs_cs_flip \
> > >  	kms_pipe_b_c_ivb \
> > >  	kms_pipe_crc_basic \
> > > --
> > > 1.9.1
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
Daniel Vetter April 9, 2015, 9:28 a.m. UTC | #4
On Thu, Apr 09, 2015 at 01:04:28AM +0000, He, Shuang wrote:
> > -----Original Message-----
> > From: He, Shuang
> > Sent: Wednesday, April 8, 2015 4:16 PM
> > To: Daniel Vetter
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: RE: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak'
> > entry in tests/Makefile.sources
> > 
> > > -----Original Message-----
> > > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> > > Vetter
> > > Sent: Wednesday, April 8, 2015 4:15 PM
> > > To: He, Shuang
> > > Cc: intel-gfx@lists.freedesktop.org
> > > Subject: Re: [Intel-gfx] [PATCH] tests: Fix duplicate 'kms_flip_event_leak'
> > > entry in tests/Makefile.sources
> > >
> > > On Tue, Apr 19, 2011 at 04:16:06AM +0800, Shuang He wrote:
> > > > Or, it will cause piglit failure to run I-G-T test case
> > > >
> > > > Signed-off-by: Shuang He <shuang.he@intel.com>
> > >
> > > How does it fail? And please fix the time on your machine, date on the
> > > mail is 2011 ;-)
> > [He, Shuang]  Piglit is now checking duplicate case name. and duplicate
> > 'kms_flip_event_leak' in I-G-T will directly lead piglit abort testing from start.
> > Following are output of it:
> > ./piglit-run.py -d tests/igt.py t
> > Error: A test has already been asigned the name: igt@kms_flip_event_leak
> > and both tests are the same.
> [He, Shuang] Could anyone follow up this one? It's blocking our testing, though we could kind of work around it.

Sorry I forgot to push out the patch, done now.
-Daniel
diff mbox

Patch

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 3e3aa57..aded08f 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -85,7 +85,6 @@  TESTS_progs_M = \
 	kms_flip \
 	kms_flip_event_leak \
 	kms_flip_tiling \
-	kms_flip_event_leak \
 	kms_mmio_vs_cs_flip \
 	kms_pipe_b_c_ivb \
 	kms_pipe_crc_basic \