From patchwork Wed Apr 27 07:41:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Feng, Boqun" X-Patchwork-Id: 735411 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3R7fj5U014363 for ; Wed, 27 Apr 2011 07:43:15 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 573EBA0CF8 for ; Wed, 27 Apr 2011 00:41:45 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CC9C5A0C81 for ; Wed, 27 Apr 2011 00:41:01 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 27 Apr 2011 00:41:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,273,1301900400"; d="scan'208";a="634687194" Received: from unknown (HELO localhost) ([10.239.47.63]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2011 00:41:00 -0700 From: "Feng, Boqun" To: intel-gfx@lists.freedesktop.org Date: Wed, 27 Apr 2011 15:41:19 +0800 Message-Id: <1303890079-2518-2-git-send-email-boqun.feng@intel.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1303890079-2518-1-git-send-email-boqun.feng@intel.com> References: <1303890079-2518-1-git-send-email-boqun.feng@intel.com> Subject: [Intel-gfx] [PATCH 2/2] drm/i915:fix irq miss in bsd ring for g4x X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 27 Apr 2011 07:43:45 +0000 (UTC) On g4x, user interrupt in bsd ring is missed. g4x and ironlake share the same bsd_ring, but their interrupt control interfaces are different. G4x use I915 while ironlake use GT. The interrupt mask reg address on g4x should be IMR, user interrupt bit in bsd ring on g4x is I915_BSD_USER_INTERRUPT Add conditional judgment about platform to find out which interrupt interface is to use. Signed-off-by: Feng, Boqun Reviewed-by: Xiang, Haihao --- drivers/gpu/drm/i915/intel_ringbuffer.c | 16 ++++++++++++---- 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 06c921f..48c21aa 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -644,8 +644,12 @@ bsd_ring_get_irq(struct intel_ring_buffer *ring) return false; spin_lock(&ring->irq_lock); - if (ring->irq_refcount++ == 0) - ironlake_enable_irq(dev_priv, GT_BSD_USER_INTERRUPT); + if (ring->irq_refcount++ == 0) { + if (IS_G4X(dev)) + i915_enable_irq(dev_priv, I915_BSD_USER_INTERRUPT); + else + ironlake_enable_irq(dev_priv, GT_BSD_USER_INTERRUPT); + } spin_unlock(&ring->irq_lock); return true; @@ -657,8 +661,12 @@ bsd_ring_put_irq(struct intel_ring_buffer *ring) drm_i915_private_t *dev_priv = dev->dev_private; spin_lock(&ring->irq_lock); - if (--ring->irq_refcount == 0) - ironlake_disable_irq(dev_priv, GT_BSD_USER_INTERRUPT); + if (--ring->irq_refcount == 0) { + if (IS_G4X(dev)) + i915_disable_irq(dev_priv, I915_BSD_USER_INTERRUPT); + else + ironlake_disable_irq(dev_priv, GT_BSD_USER_INTERRUPT); + } spin_unlock(&ring->irq_lock); }