diff mbox

=?utf-8?q?=5BPATCH_1/2=5D_Add_attachment_token_DRI2Bu?= =?utf-8?q?fferHiz?=

Message ID 1307232391-26973-2-git-send-email-chad@chad-versace.us
State New, archived
Headers show

Commit Message

Chad Versace June 5, 2011, 12:06 a.m. UTC
None

Comments

Kenneth Graunke June 5, 2011, 8:53 a.m. UTC | #1
On 06/04/2011 05:06 PM, Chad Versace wrote:
> ... and bump version to 2.6.
>
> Signed-off-by: Chad Versace<chad@chad-versace.us>
> ---
>   configure.ac  |    2 +-
>   dri2proto.txt |    6 +++++-
>   dri2tokens.h  |    1 +
>   3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 297be0e..d671f5a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,5 +1,5 @@
>   AC_PREREQ([2.60])
> -AC_INIT([DRI2Proto], [2.5], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> +AC_INIT([DRI2Proto], [2.6], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
>   AM_INIT_AUTOMAKE([foreign dist-bzip2])
>   AM_MAINTAINER_MODE
>
> diff --git a/dri2proto.txt b/dri2proto.txt
> index dc46e58..df763c7 100644
> --- a/dri2proto.txt
> +++ b/dri2proto.txt
> @@ -178,7 +178,8 @@ DRI2ATTACHMENT { DRI2BufferFrontLeft
>   	       	 DRI2BufferAccum
>   		 DRI2BufferFakeFrontLeft
>   		 DRI2BufferFakeFrontRight
> -		 DRI2BufferDepthStencil }
> +		 DRI2BufferDepthStencil
> +		 DRI2BufferHiz }
>
>   	These values describe various attachment points for DRI2
>   	buffers.
> @@ -509,6 +510,8 @@ The DRI2 extension has undergone a number of revisions before
>
>   	2.3: Added the DRI2InvalidateBuffers event.
>
> +	2.6: Enlightenment attained.  Added the DRI2BufferHiz attachment.
> +

I hate to be a killjoy, but I'd leave out the first sentence lest 
someone think this is to support Enlightenment/EFL (enlightenment.org).

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

>   Compatibility up to 2.0 is not preserved, but was also never released.
>
>
> @@ -569,6 +572,7 @@ A.1 Common Types
>   	0x7	DRI2BufferFakeFrontLeft
>   	0x8	DRI2BufferFakeFrontRight
>   	0x9	DRI2BufferDepthStencil
> +	0xa	DRI2BufferHiz
>   ????
>   	Used to encode the possible attachment points.  The attachment
>   	DRI2BufferDepthStencil is only available with protocol version 1.1 or
> diff --git a/dri2tokens.h b/dri2tokens.h
> index 7804e4d..16c9008 100644
> --- a/dri2tokens.h
> +++ b/dri2tokens.h
> @@ -43,6 +43,7 @@
>   #define DRI2BufferFakeFrontLeft		7
>   #define DRI2BufferFakeFrontRight	8
>   #define DRI2BufferDepthStencil		9
> +#define DRI2BufferHiz			10
>
>   #define DRI2DriverDRI			0
>   #define DRI2DriverVDPAU			1
Chad Versace June 6, 2011, 2:32 a.m. UTC | #2
On Sun, 05 Jun 2011 01:53:29 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> On 06/04/2011 05:06 PM, Chad Versace wrote:
> > ... and bump version to 2.6.
> >
> > Signed-off-by: Chad Versace<chad@chad-versace.us>
> > ---
> >   configure.ac  |    2 +-
> >   dri2proto.txt |    6 +++++-
> >   dri2tokens.h  |    1 +
> >   3 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 297be0e..d671f5a 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -1,5 +1,5 @@
> >   AC_PREREQ([2.60])
> > -AC_INIT([DRI2Proto], [2.5], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> > +AC_INIT([DRI2Proto], [2.6], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> >   AM_INIT_AUTOMAKE([foreign dist-bzip2])
> >   AM_MAINTAINER_MODE
> >
> > diff --git a/dri2proto.txt b/dri2proto.txt
> > index dc46e58..df763c7 100644
> > --- a/dri2proto.txt
> > +++ b/dri2proto.txt
> > @@ -178,7 +178,8 @@ DRI2ATTACHMENT { DRI2BufferFrontLeft
> >   	       	 DRI2BufferAccum
> >   		 DRI2BufferFakeFrontLeft
> >   		 DRI2BufferFakeFrontRight
> > -		 DRI2BufferDepthStencil }
> > +		 DRI2BufferDepthStencil
> > +		 DRI2BufferHiz }
> >
> >   	These values describe various attachment points for DRI2
> >   	buffers.
> > @@ -509,6 +510,8 @@ The DRI2 extension has undergone a number of revisions before
> >
> >   	2.3: Added the DRI2InvalidateBuffers event.
> >
> > +	2.6: Enlightenment attained.  Added the DRI2BufferHiz attachment.
> > +
> 
> I hate to be a killjoy, but I'd leave out the first sentence lest 
> someone think this is to support Enlightenment/EFL (enlightenment.org).
> 
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

It's not evident from the hunk, but I was just following the silly precedent
in previous version bumps.

>	2.0: Awesomeness!
>
>	2.1: True excellence.  Added DRI2GetBuffersWithFormat to allow
>             more flexible object creation.
>
>	2.2: Approaching perfection.  Added requests for swapbuffers,
>             MSC and SBC related requests, and events.
Kenneth Graunke June 6, 2011, 7:22 a.m. UTC | #3
On 06/05/2011 07:32 PM, Chad Versace wrote:
> On Sun, 05 Jun 2011 01:53:29 -0700, Kenneth Graunke<kenneth@whitecape.org>  wrote:
>> I hate to be a killjoy, but I'd leave out the first sentence lest
>> someone think this is to support Enlightenment/EFL (enlightenment.org).
>>
>> Reviewed-by: Kenneth Graunke<kenneth@whitecape.org>
>
> It's not evident from the hunk, but I was just following the silly precedent
> in previous version bumps.
>
>> 	2.0: Awesomeness!
>>
>> 	2.1: True excellence.  Added DRI2GetBuffersWithFormat to allow
>>              more flexible object creation.
>>
>> 	2.2: Approaching perfection.  Added requests for swapbuffers,
>>              MSC and SBC related requests, and events.

Oh :) I should have checked first...by all means, go ahead then!
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 297be0e..d671f5a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@ 
 AC_PREREQ([2.60])
-AC_INIT([DRI2Proto], [2.5], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
+AC_INIT([DRI2Proto], [2.6], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
 AM_INIT_AUTOMAKE([foreign dist-bzip2])
 AM_MAINTAINER_MODE
 
diff --git a/dri2proto.txt b/dri2proto.txt
index dc46e58..df763c7 100644
--- a/dri2proto.txt
+++ b/dri2proto.txt
@@ -178,7 +178,8 @@  DRI2ATTACHMENT { DRI2BufferFrontLeft
 	       	 DRI2BufferAccum
 		 DRI2BufferFakeFrontLeft
 		 DRI2BufferFakeFrontRight
-		 DRI2BufferDepthStencil }
+		 DRI2BufferDepthStencil
+		 DRI2BufferHiz }
 
 	These values describe various attachment points for DRI2
 	buffers.
@@ -509,6 +510,8 @@  The DRI2 extension has undergone a number of revisions before
 
 	2.3: Added the DRI2InvalidateBuffers event.
 
+	2.6: Enlightenment attained.  Added the DRI2BufferHiz attachment.
+
 Compatibility up to 2.0 is not preserved, but was also never released.
 
 
@@ -569,6 +572,7 @@  A.1 Common Types
 	0x7	DRI2BufferFakeFrontLeft
 	0x8	DRI2BufferFakeFrontRight
 	0x9	DRI2BufferDepthStencil
+	0xa	DRI2BufferHiz
 ????
 	Used to encode the possible attachment points.  The attachment
 	DRI2BufferDepthStencil is only available with protocol version 1.1 or
diff --git a/dri2tokens.h b/dri2tokens.h
index 7804e4d..16c9008 100644
--- a/dri2tokens.h
+++ b/dri2tokens.h
@@ -43,6 +43,7 @@ 
 #define DRI2BufferFakeFrontLeft		7
 #define DRI2BufferFakeFrontRight	8
 #define DRI2BufferDepthStencil		9
+#define DRI2BufferHiz			10
 
 #define DRI2DriverDRI			0
 #define DRI2DriverVDPAU			1