From patchwork Tue Jul 3 09:28:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 1150341 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id DEFB1DFF72 for ; Tue, 3 Jul 2012 10:53:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5E829F6F7 for ; Tue, 3 Jul 2012 03:53:20 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id E22849F504 for ; Tue, 3 Jul 2012 03:34:56 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id hm11so2984141wib.12 for ; Tue, 03 Jul 2012 03:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=szPRrli1efo1i0+k7nONvACfkMrymJ2NTh2QumS7mOY=; b=FmQulyBFbh5zTZMBQ5OhdPBTmnRtv72T+klzos/epX7k8NWw3stSm55US4ZtNPOr3R qdDlVKO6J4bAzvoetJf7agqup5QHD3pzQ2MkWK16eEUb50GeC6a6HG1TEqgFMuPpaXxk DkATRDhWyHe63EXIkpKT2TiGZ+ikX4cFCCUz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=szPRrli1efo1i0+k7nONvACfkMrymJ2NTh2QumS7mOY=; b=LNRUYV+xnQ4LrvtRW6sABvpyRuJHPuJ6LVjgkuVgCHOVs0sh4T/D2otbLjp0ANbt1N nDMWB+ZB7+yUNPHJb/XxiHG/GEkQiZgRKxRPQxV68zOVmuz3Qq5oulnoPFUPvkq1mOy4 Ae4byjclv/3lbmxiNc4C24AQi9bFIyzyNtININQ92kDk72jlp0w5SUppGgU5aoz7mpxJ j6CUwJf1aok3TZxthx4akwwrDNb7yaE2axj7OlL0lLtI4lBYnLWvDQ0DWsM7z3zuFnAH yIum5y/ErH/SgUU8mD8fD6VNFS7dXEGa6loTqU7o1p7ljkDKLap3ek9l4RDXCnf6f9Ua daFQ== Received: by 10.180.104.200 with SMTP id gg8mr24061208wib.14.1341311696593; Tue, 03 Jul 2012 03:34:56 -0700 (PDT) Received: from wespe.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPS id e9sm14845138wiw.10.2012.07.03.03.34.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Jul 2012 03:34:55 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Tue, 3 Jul 2012 11:28:16 +0200 Message-Id: <1341307715-3886-25-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1341307715-3886-1-git-send-email-daniel.vetter@ffwll.ch> References: <1341307715-3886-1-git-send-email-daniel.vetter@ffwll.ch> X-Gm-Message-State: ALoCoQkz9Ztn/FTmrUbE/mQ5ss8cIdlOKibKJuRdKN2+ysrdlUXJrKKgpEUQNcPSL8MoNbOMJYd6 Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 24/43] drm/fb helper: don't call drm_crtc_helper_set_config X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Go through the interface vtable instead, because not everyone might be using the crtc helper code. Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 5683b7f..bf97c0a 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -228,7 +228,7 @@ bool drm_fb_helper_restore_fbdev_mode(struct drm_fb_helper *fb_helper) int i, ret; for (i = 0; i < fb_helper->crtc_count; i++) { struct drm_mode_set *mode_set = &fb_helper->crtc_info[i].mode_set; - ret = drm_crtc_helper_set_config(mode_set); + ret = mode_set->crtc->funcs->set_config(mode_set); if (ret) error = true; }