From patchwork Wed Jul 11 14:28:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 1184101 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id B68713FC5A for ; Wed, 11 Jul 2012 16:19:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8846AA0ECE for ; Wed, 11 Jul 2012 09:19:52 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id DA85F9E94F for ; Wed, 11 Jul 2012 08:36:27 -0700 (PDT) Received: by mail-wi0-f177.google.com with SMTP id hm11so928073wib.12 for ; Wed, 11 Jul 2012 08:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=9+KGrUbIRK8hN6xcOTeV+WLSOpsTzlYt4vGlmI8k9wI=; b=DRtQsZZHVxZljWzhyBv0SRtvbQ9IinsVrNWHv6Xo7zIY7ZjkBjpZw+M9gqLn60np/S Fgwyx/IduMa4KKSMXqKoJqhONPbx1QG2XLwrkZLaEteuVaEBBTq4MtdG1Z8GTbfHgsKP uxc9Z6TCkU3q72ijirVJUx6KyvgA4spFv2QHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=9+KGrUbIRK8hN6xcOTeV+WLSOpsTzlYt4vGlmI8k9wI=; b=BoL9ROhNQ+op0lHnO/j/lhOCpD1jvR+OnHE3vVe9XPjutlqEaMVleRaA8KgAJ/XbV2 SF9fd/PWVU+bjyl4uNf2fTGUBiw5zwBs+OwN/nPtp4rR8g6yZF+7VY16djTqfOjApxZt VSntM+OYMkVSy/zH9fWkvXQZzg6XpUDAfs3+SHgyS9D32CWNwl7rMKkFAlvtnVVjjxn9 OPdDled8NpazFpi7XUhTcxXSKgguKp3brq8RnuaIkskUuD66rrQ+/kiExXaadqxH80ZQ 6Gb9RblKiefW4ptt4l3i8WG82TfEpZe3v4AmqhBNyA+N+66yLXCUddoBuzlshC6Q64HY paEQ== Received: by 10.217.1.8 with SMTP id m8mr5303232wes.118.1342020986886; Wed, 11 Jul 2012 08:36:26 -0700 (PDT) Received: from wespe.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPS id bc2sm5777080wib.0.2012.07.11.08.36.25 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 Jul 2012 08:36:25 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Wed, 11 Jul 2012 16:28:40 +0200 Message-Id: <1342016944-23395-58-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> References: <1342016944-23395-1-git-send-email-daniel.vetter@ffwll.ch> X-Gm-Message-State: ALoCoQl9ZF+7LLJnsxWYCop+0QJQ15ERvctd5oJfyvCS/gmnpAGvSH2TvuSWd0XOpYqdaRM3prtv Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 57/81] drm/i915: remove crtc disabling special case X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Originally this has been introduced in commit 6eebd6bb5f1ea04f04019e5c39f87a0f17ffb472 Author: Chris Wilson Date: Mon Nov 28 21:10:05 2011 +0000 drm: Fix lack of CRTC disable for drm_crtc_helper_set_config(.fb=NULL) With the improvements of the output state staging and no longer overwriting crtc->fb before the hw state is updated we can now handle crtc disabling as part of the normal modeset sequence. Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 25 ------------------------- 1 files changed, 0 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 19ef083..edd7efc 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -6585,30 +6585,6 @@ static bool intel_encoder_crtc_ok(struct drm_encoder *encoder, return false; } -static int -intel_crtc_helper_disable(struct drm_crtc *crtc) -{ - struct drm_device *dev = crtc->dev; - struct drm_connector *connector; - struct drm_encoder *encoder; - - /* Decouple all encoders and their attached connectors from this crtc */ - list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) { - if (encoder->crtc != crtc) - continue; - - list_for_each_entry(connector, &dev->mode_config.connector_list, head) { - if (connector->encoder != encoder) - continue; - - connector->encoder = NULL; - } - } - - drm_helper_disable_unused_functions(dev); - return 0; -} - static void intel_crtc_prepare_encoders(struct drm_device *dev) { @@ -7012,7 +6988,6 @@ static int intel_crtc_set_config(struct drm_mode_set *set) (int)set->num_connectors, set->x, set->y); } else { DRM_DEBUG_KMS("[CRTC:%d] [NOFB]\n", set->crtc->base.id); - return intel_crtc_helper_disable(set->crtc); } dev = set->crtc->dev;