diff mbox

drm/i915: add debug logging to ASLE backlight set requests

Message ID 1349090731-23917-1-git-send-email-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jani Nikula Oct. 1, 2012, 11:25 a.m. UTC
Make it easier to track backlight set requests coming through ASLE instead
of the driver's own backlight sysfs interface. We've had enough of
backlight issues to warrant some extra debug logs in the area.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

I thought I'd sent this a while back, but I guess not after all...?
---
 drivers/gpu/drm/i915/intel_opregion.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Daniel Vetter Oct. 1, 2012, 2:24 p.m. UTC | #1
On Mon, Oct 01, 2012 at 02:25:30PM +0300, Jani Nikula wrote:
> Make it easier to track backlight set requests coming through ASLE instead
> of the driver's own backlight sysfs interface. We've had enough of
> backlight issues to warrant some extra debug logs in the area.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Looks nice, applied to dinq.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index e27c170..0f2db16 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -154,6 +154,8 @@  static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 	struct opregion_asle __iomem *asle = dev_priv->opregion.asle;
 	u32 max;
 
+	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
+
 	if (!(bclp & ASLE_BCLP_VALID))
 		return ASLE_BACKLIGHT_FAILED;