From patchwork Wed Oct 10 13:04:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Imre Deak X-Patchwork-Id: 1573611 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 4859F40135 for ; Wed, 10 Oct 2012 13:08:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C5499E8FD for ; Wed, 10 Oct 2012 06:08:08 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 0397A9E808 for ; Wed, 10 Oct 2012 06:04:57 -0700 (PDT) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 10 Oct 2012 06:04:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,564,1344236400"; d="scan'208";a="202780283" Received: from ideak-desk.fi.intel.com (HELO localhost) ([10.237.72.98]) by azsmga001.ch.intel.com with ESMTP; 10 Oct 2012 06:04:56 -0700 From: Imre Deak To: intel-gfx@lists.freedesktop.org Date: Wed, 10 Oct 2012 16:04:42 +0300 Message-Id: <1349874285-31536-6-git-send-email-imre.deak@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1349874285-31536-1-git-send-email-imre.deak@intel.com> References: <1349874285-31536-1-git-send-email-imre.deak@intel.com> Subject: [Intel-gfx] [PATCH 5/8] fix warn in sysfs_{rc6, rps}*: ignoring return value of 'fscanf' X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Signed-off-by: Imre Deak --- tests/sysfs_rc6_residency.c | 5 ++++- tests/sysfs_rps.c | 6 +++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/sysfs_rc6_residency.c b/tests/sysfs_rc6_residency.c index 2f33697..cd62e77 100644 --- a/tests/sysfs_rc6_residency.c +++ b/tests/sysfs_rc6_residency.c @@ -38,6 +38,7 @@ static unsigned int readit(const char *path) { unsigned int ret; + int scanned; FILE *file; file = fopen(path, "r"); @@ -45,7 +46,9 @@ static unsigned int readit(const char *path) fprintf(stderr, "Couldn't open %s (%d)\n", path, errno); abort(); } - fscanf(file, "%u", &ret); + scanned = fscanf(file, "%u", &ret); + assert(scanned == 1); + fclose(file); return ret; diff --git a/tests/sysfs_rps.c b/tests/sysfs_rps.c index b830797..833c2e9 100644 --- a/tests/sysfs_rps.c +++ b/tests/sysfs_rps.c @@ -64,9 +64,13 @@ struct junk { static int readval(FILE *filp) { int val; + int scanned; + fflush(filp); rewind(filp); - fscanf(filp, "%d", &val); + scanned = fscanf(filp, "%d", &val); + assert(scanned == 1); + return val; }