diff mbox

[6/9] drm/i915: BUG on impossible pch dp port

Message ID 1351241899-7870-7-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Oct. 26, 2012, 8:58 a.m. UTC 
Since it is one. We need to move this code to encoder specific callbacks
eventually, to kill all that inversion of control ...

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Paulo Zanoni Oct. 26, 2012, 3:04 p.m. UTC | #1 
Hi

2012/10/26 Daniel Vetter <daniel.vetter@ffwll.ch>:
> Since it is one. We need to move this code to encoder specific callbacks
> eventually, to kill all that inversion of control ...
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 8ab0fa5..991adc1 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3092,9 +3092,7 @@ static void ironlake_pch_enable(struct drm_crtc *crtc)
>                         temp |= TRANS_DP_PORT_SEL_D;
>                         break;
>                 default:
> -                       DRM_DEBUG_KMS("Wrong PCH DP port return. Guess port B\n");
> -                       temp |= TRANS_DP_PORT_SEL_B;
> -                       break;
> +                       BUG();
>                 }
>
>                 I915_WRITE(reg, temp);
> --
> 1.7.11.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8ab0fa5..991adc1 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3092,9 +3092,7 @@  static void ironlake_pch_enable(struct drm_crtc *crtc)
 			temp |= TRANS_DP_PORT_SEL_D;
 			break;
 		default:
-			DRM_DEBUG_KMS("Wrong PCH DP port return. Guess port B\n");
-			temp |= TRANS_DP_PORT_SEL_B;
-			break;
+			BUG();
 		}
 
 		I915_WRITE(reg, temp);