| Message ID | 1352118507-6933-9-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi 2012/11/5 Daniel Vetter <daniel.vetter@ffwll.ch>: > Especially getting rid of all things lvds is ... great! > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/i915/intel_display.c | 114 +---------------------------------- > 1 file changed, 1 insertion(+), 113 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 68c0524..27fc014 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -5465,23 +5465,14 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, > int pipe = intel_crtc->pipe; > int plane = intel_crtc->plane; > int num_connectors = 0; > - intel_clock_t clock, reduced_clock; > - u32 dpll = 0, fp = 0, fp2 = 0; > - bool ok, has_reduced_clock = false; > - bool is_lvds = false, is_dp = false, is_cpu_edp = false; > + bool is_dp = false, is_cpu_edp = false; > struct intel_encoder *encoder; > - u32 temp; > int ret; > bool dither; > > for_each_encoder_on_crtc(dev, crtc, encoder) { > switch (encoder->type) { > - case INTEL_OUTPUT_LVDS: > - is_lvds = true; > - break; > case INTEL_OUTPUT_DISPLAYPORT: > - is_dp = true; > - break; > case INTEL_OUTPUT_EDP: > is_dp = true; > if (!intel_encoder_is_pch_edp(&encoder->base)) > @@ -5512,93 +5503,15 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, > if (!intel_ddi_pll_mode_set(crtc, adjusted_mode->clock)) > return -EINVAL; > > - if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { > - ok = ironlake_compute_clocks(crtc, adjusted_mode, &clock, > - &has_reduced_clock, > - &reduced_clock); > - if (!ok) { > - DRM_ERROR("Couldn't find PLL settings for mode!\n"); > - return -EINVAL; > - } > - } > - > /* Ensure that the cursor is valid for the new mode before changing... */ > intel_crtc_update_cursor(crtc, true); > > /* determine panel color depth */ > dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode); Patch doesn't apply because on my tree (based on drm-intel-nightly) this line uses "adjusted_mode" instead of "mode". I have no idea if this is a problem or not, but maybe it rings a bell for you. For completeness of your patch, you may also want to remove the following lines: Check obsoleted by your "check soulmates" patch: /* We are not sure yet this won't happen. */ WARN(!HAS_PCH_LPT(dev), "Unexpected PCH type %d\n", INTEL_PCH_TYPE(dev)); The only ibx/cpt check remaining: if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { /* For non-DP output, clear any trans DP clock recovery * setting.*/ I915_WRITE(TRANSDATA_M1(pipe), 0); I915_WRITE(TRANSDATA_N1(pipe), 0); I915_WRITE(TRANSDPLINK_M1(pipe), 0); I915_WRITE(TRANSDPLINK_N1(pipe), 0); } > - if (is_lvds && dev_priv->lvds_dither) > - dither = true; > > DRM_DEBUG_KMS("Mode for pipe %d:\n", pipe); > drm_mode_debug_printmodeline(mode); > > - if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { > - fp = clock.n << 16 | clock.m1 << 8 | clock.m2; > - if (has_reduced_clock) > - fp2 = reduced_clock.n << 16 | reduced_clock.m1 << 8 | > - reduced_clock.m2; > - > - dpll = ironlake_compute_dpll(intel_crtc, adjusted_mode, &clock, > - fp); > - > - /* CPU eDP is the only output that doesn't need a PCH PLL of its > - * own on pre-Haswell/LPT generation */ > - if (!is_cpu_edp) { > - struct intel_pch_pll *pll; > - > - pll = intel_get_pch_pll(intel_crtc, dpll, fp); > - if (pll == NULL) { > - DRM_DEBUG_DRIVER("failed to find PLL for pipe %d\n", > - pipe); > - return -EINVAL; > - } > - } else > - intel_put_pch_pll(intel_crtc); > - > - /* The LVDS pin pair needs to be on before the DPLLs are > - * enabled. This is an exception to the general rule that > - * mode_set doesn't turn things on. > - */ > - if (is_lvds) { > - temp = I915_READ(PCH_LVDS); > - temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP; > - if (HAS_PCH_CPT(dev)) { > - temp &= ~PORT_TRANS_SEL_MASK; > - temp |= PORT_TRANS_SEL_CPT(pipe); > - } else { > - if (pipe == 1) > - temp |= LVDS_PIPEB_SELECT; > - else > - temp &= ~LVDS_PIPEB_SELECT; > - } > - > - /* set the corresponsding LVDS_BORDER bit */ > - temp |= dev_priv->lvds_border_bits; > - /* Set the B0-B3 data pairs corresponding to whether > - * we're going to set the DPLLs for dual-channel mode or > - * not. > - */ > - if (clock.p2 == 7) > - temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP; > - else > - temp &= ~(LVDS_B0B3_POWER_UP | > - LVDS_CLKB_POWER_UP); > - > - /* It would be nice to set 24 vs 18-bit mode > - * (LVDS_A3_POWER_UP) appropriately here, but we need to > - * look more thoroughly into how panels behave in the > - * two modes. > - */ > - temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY); > - if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) > - temp |= LVDS_HSYNC_POLARITY; > - if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) > - temp |= LVDS_VSYNC_POLARITY; > - I915_WRITE(PCH_LVDS, temp); > - } > - } > - > if (is_dp && !is_cpu_edp) { > intel_dp_set_m_n(crtc, mode, adjusted_mode); > } else { > @@ -5613,31 +5526,6 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, > } > > intel_crtc->lowfreq_avail = false; > - if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { > - if (intel_crtc->pch_pll) { > - I915_WRITE(intel_crtc->pch_pll->pll_reg, dpll); > - > - /* Wait for the clocks to stabilize. */ > - POSTING_READ(intel_crtc->pch_pll->pll_reg); > - udelay(150); > - > - /* The pixel multiplier can only be updated once the > - * DPLL is enabled and the clocks are stable. > - * > - * So write it again. > - */ > - I915_WRITE(intel_crtc->pch_pll->pll_reg, dpll); > - } > - > - if (intel_crtc->pch_pll) { > - if (is_lvds && has_reduced_clock && i915_powersave) { > - I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp2); > - intel_crtc->lowfreq_avail = true; > - } else { > - I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp); > - } > - } > - } > > intel_set_pipe_timings(intel_crtc, mode, adjusted_mode); > > -- > 1.7.11.7 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Nov 16, 2012 at 7:28 PM, Paulo Zanoni <przanoni@gmail.com> wrote: > Hi > > 2012/11/5 Daniel Vetter <daniel.vetter@ffwll.ch>: >> Especially getting rid of all things lvds is ... great! >> >> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> --- >> intel_crtc_update_cursor(crtc, true); >> >> /* determine panel color depth */ >> dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode); > > Patch doesn't apply because on my tree (based on drm-intel-nightly) > this line uses "adjusted_mode" instead of "mode". I have no idea if > this is a problem or not, but maybe it rings a bell for you. Yeah, that's just Jani's dp 6bpc fix getting a bit in the way. Will fix up. > For completeness of your patch, you may also want to remove the following lines: > > Check obsoleted by your "check soulmates" patch: > > /* We are not sure yet this won't happen. */ > WARN(!HAS_PCH_LPT(dev), "Unexpected PCH type %d\n", > INTEL_PCH_TYPE(dev)); Will remove. > The only ibx/cpt check remaining: > > if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { > /* For non-DP output, clear any trans DP clock > recovery > * setting.*/ > I915_WRITE(TRANSDATA_M1(pipe), 0); > I915_WRITE(TRANSDATA_N1(pipe), 0); > I915_WRITE(TRANSDPLINK_M1(pipe), 0); > I915_WRITE(TRANSDPLINK_N1(pipe), 0); This will die in one of the dp patches. -Daniel
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 68c0524..27fc014 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -5465,23 +5465,14 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, int pipe = intel_crtc->pipe; int plane = intel_crtc->plane; int num_connectors = 0; - intel_clock_t clock, reduced_clock; - u32 dpll = 0, fp = 0, fp2 = 0; - bool ok, has_reduced_clock = false; - bool is_lvds = false, is_dp = false, is_cpu_edp = false; + bool is_dp = false, is_cpu_edp = false; struct intel_encoder *encoder; - u32 temp; int ret; bool dither; for_each_encoder_on_crtc(dev, crtc, encoder) { switch (encoder->type) { - case INTEL_OUTPUT_LVDS: - is_lvds = true; - break; case INTEL_OUTPUT_DISPLAYPORT: - is_dp = true; - break; case INTEL_OUTPUT_EDP: is_dp = true; if (!intel_encoder_is_pch_edp(&encoder->base)) @@ -5512,93 +5503,15 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, if (!intel_ddi_pll_mode_set(crtc, adjusted_mode->clock)) return -EINVAL; - if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { - ok = ironlake_compute_clocks(crtc, adjusted_mode, &clock, - &has_reduced_clock, - &reduced_clock); - if (!ok) { - DRM_ERROR("Couldn't find PLL settings for mode!\n"); - return -EINVAL; - } - } - /* Ensure that the cursor is valid for the new mode before changing... */ intel_crtc_update_cursor(crtc, true); /* determine panel color depth */ dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode); - if (is_lvds && dev_priv->lvds_dither) - dither = true; DRM_DEBUG_KMS("Mode for pipe %d:\n", pipe); drm_mode_debug_printmodeline(mode); - if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { - fp = clock.n << 16 | clock.m1 << 8 | clock.m2; - if (has_reduced_clock) - fp2 = reduced_clock.n << 16 | reduced_clock.m1 << 8 | - reduced_clock.m2; - - dpll = ironlake_compute_dpll(intel_crtc, adjusted_mode, &clock, - fp); - - /* CPU eDP is the only output that doesn't need a PCH PLL of its - * own on pre-Haswell/LPT generation */ - if (!is_cpu_edp) { - struct intel_pch_pll *pll; - - pll = intel_get_pch_pll(intel_crtc, dpll, fp); - if (pll == NULL) { - DRM_DEBUG_DRIVER("failed to find PLL for pipe %d\n", - pipe); - return -EINVAL; - } - } else - intel_put_pch_pll(intel_crtc); - - /* The LVDS pin pair needs to be on before the DPLLs are - * enabled. This is an exception to the general rule that - * mode_set doesn't turn things on. - */ - if (is_lvds) { - temp = I915_READ(PCH_LVDS); - temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP; - if (HAS_PCH_CPT(dev)) { - temp &= ~PORT_TRANS_SEL_MASK; - temp |= PORT_TRANS_SEL_CPT(pipe); - } else { - if (pipe == 1) - temp |= LVDS_PIPEB_SELECT; - else - temp &= ~LVDS_PIPEB_SELECT; - } - - /* set the corresponsding LVDS_BORDER bit */ - temp |= dev_priv->lvds_border_bits; - /* Set the B0-B3 data pairs corresponding to whether - * we're going to set the DPLLs for dual-channel mode or - * not. - */ - if (clock.p2 == 7) - temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP; - else - temp &= ~(LVDS_B0B3_POWER_UP | - LVDS_CLKB_POWER_UP); - - /* It would be nice to set 24 vs 18-bit mode - * (LVDS_A3_POWER_UP) appropriately here, but we need to - * look more thoroughly into how panels behave in the - * two modes. - */ - temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY); - if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) - temp |= LVDS_HSYNC_POLARITY; - if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) - temp |= LVDS_VSYNC_POLARITY; - I915_WRITE(PCH_LVDS, temp); - } - } - if (is_dp && !is_cpu_edp) { intel_dp_set_m_n(crtc, mode, adjusted_mode); } else { @@ -5613,31 +5526,6 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc, } intel_crtc->lowfreq_avail = false; - if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) { - if (intel_crtc->pch_pll) { - I915_WRITE(intel_crtc->pch_pll->pll_reg, dpll); - - /* Wait for the clocks to stabilize. */ - POSTING_READ(intel_crtc->pch_pll->pll_reg); - udelay(150); - - /* The pixel multiplier can only be updated once the - * DPLL is enabled and the clocks are stable. - * - * So write it again. - */ - I915_WRITE(intel_crtc->pch_pll->pll_reg, dpll); - } - - if (intel_crtc->pch_pll) { - if (is_lvds && has_reduced_clock && i915_powersave) { - I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp2); - intel_crtc->lowfreq_avail = true; - } else { - I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp); - } - } - } intel_set_pipe_timings(intel_crtc, mode, adjusted_mode);
Especially getting rid of all things lvds is ... great! Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/i915/intel_display.c | 114 +---------------------------------- 1 file changed, 1 insertion(+), 113 deletions(-)