diff mbox

[1/4] drm/i915: intel_prepare_ddi_buffers should be static

Message ID 1353691840-9913-1-git-send-email-przanoni@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Paulo Zanoni Nov. 23, 2012, 5:30 p.m. UTC 
From: Paulo Zanoni <paulo.r.zanoni@intel.com>

It's not even declared on header files.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Imre Deak Nov. 29, 2012, 1:39 p.m. UTC | #1 
On Fri, 2012-11-23 at 15:30 -0200, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> It's not even declared on header files.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

On the series:
Reviewed-by: Imre Deak <imre.deak@intel.com>
Daniel Vetter Nov. 29, 2012, 1:59 p.m. UTC | #2 
On Thu, Nov 29, 2012 at 03:39:09PM +0200, Imre Deak wrote:
> On Fri, 2012-11-23 at 15:30 -0200, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > It's not even declared on header files.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> On the series:
> Reviewed-by: Imre Deak <imre.deak@intel.com>

Series queued for -next, thanks for the patches&review.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 852012b..16d3e78 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -84,7 +84,8 @@  static enum port intel_ddi_get_encoder_port(struct intel_encoder *intel_encoder)
  * in either FDI or DP modes only, as HDMI connections will work with both
  * of those
  */
-void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port, bool use_fdi_mode)
+static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
+				      bool use_fdi_mode)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	u32 reg;