From patchwork Wed Dec 12 19:50:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Lespiau X-Patchwork-Id: 1870191 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 2EB2DDF266 for ; Wed, 12 Dec 2012 19:52:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 10EA0E5DEC for ; Wed, 12 Dec 2012 11:52:20 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A9A0E61E4 for ; Wed, 12 Dec 2012 11:50:53 -0800 (PST) Received: by mail-wi0-f169.google.com with SMTP id hq12so3242722wib.0 for ; Wed, 12 Dec 2012 11:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; bh=0uL0eCyop4YNBnBYX6BRXyq4+uYDt2OIJ+XbF4rsZpU=; b=ISNFTN4MgJr9VymIt+78gcMKlEvtdUiFe0xYhq2mKOEhQsZdCQyTjrm5F/mP5lPPfi bslrEwcXYzFLYwf3/5HqOQ27a7/VBFtMkhZIXteKzTbDD3iAxa27dm4sbipDL2LHjARq ictR6mZl3PILYI/8U/ntRvO13ua2DtQSqtyWaFp3aJiIvEI8nUtUPkICl1KhVc+w/F3m rCOKHu9wceioHTVERdA00xPD5TD9yR6BEPruNrNmnRiY6UclS7Zy7ZSo+IDSaJXFzOxM sMgcgSFeYV+fmOqMoe3zB9wtRkQ+bPnMYNSI5vnTsEyQ36cy4nUYYjjwfDJPTLSablfB LbsQ== Received: by 10.194.123.105 with SMTP id lz9mr4009869wjb.43.1355341853116; Wed, 12 Dec 2012 11:50:53 -0800 (PST) Received: from localhost.localdomain ([83.217.123.106]) by mx.google.com with ESMTPS id y3sm4474563wix.6.2012.12.12.11.50.52 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 12 Dec 2012 11:50:52 -0800 (PST) From: Damien Lespiau To: intel-gfx@lists.freedesktop.org Date: Wed, 12 Dec 2012 19:50:41 +0000 Message-Id: <1355341841-4595-4-git-send-email-damien.lespiau@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1355341841-4595-1-git-send-email-damien.lespiau@gmail.com> References: <1355341841-4595-1-git-send-email-damien.lespiau@gmail.com> Subject: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Don't log the DPCD if we are disconnected X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org From: Damien Lespiau It's a bit useless to print out an all null DPCD when we are disconnected and just clutter the debug logs. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index fe3c22f..42058fa 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -2362,13 +2362,13 @@ intel_dp_detect(struct drm_connector *connector, bool force) else status = g4x_dp_detect(intel_dp); + if (status != connector_status_connected) + return status; + hex_dump_to_buffer(intel_dp->dpcd, sizeof(intel_dp->dpcd), 32, 1, dpcd_hex_dump, sizeof(dpcd_hex_dump), false); DRM_DEBUG_KMS("DPCD: %s\n", dpcd_hex_dump); - if (status != connector_status_connected) - return status; - intel_dp_probe_oui(intel_dp); if (intel_dp->force_audio != HDMI_AUDIO_AUTO) {