diff mbox

drm/i915: dump UTS_RELEASE into the error_state

Message ID 1358954195-24903-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Jan. 23, 2013, 3:16 p.m. UTC
Useful for statistics or on overflowing bug reports to keep things all
lined up.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/i915_debugfs.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Chris Wilson Jan. 23, 2013, 3:20 p.m. UTC | #1
On Wed, Jan 23, 2013 at 04:16:35PM +0100, Daniel Vetter wrote:
> Useful for statistics or on overflowing bug reports to keep things all
> lined up.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I should have added something like this long ago...
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Daniel Vetter Jan. 23, 2013, 4:30 p.m. UTC | #2
On Wed, Jan 23, 2013 at 03:20:45PM +0000, Chris Wilson wrote:
> On Wed, Jan 23, 2013 at 04:16:35PM +0100, Daniel Vetter wrote:
> > Useful for statistics or on overflowing bug reports to keep things all
> > lined up.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> I should have added something like this long ago...
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
Chris Wilson Jan. 23, 2013, 4:37 p.m. UTC | #3
On Wed, Jan 23, 2013 at 05:30:46PM +0100, Daniel Vetter wrote:
> On Wed, Jan 23, 2013 at 03:20:45PM +0000, Chris Wilson wrote:
> > On Wed, Jan 23, 2013 at 04:16:35PM +0100, Daniel Vetter wrote:
> > > Useful for statistics or on overflowing bug reports to keep things all
> > > lined up.
> > > 
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> > I should have added something like this long ago...
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Queued for -next, thanks for the review.

Pretty please for stable?
-Chris
Daniel Vetter Jan. 23, 2013, 4:57 p.m. UTC | #4
On Wed, Jan 23, 2013 at 04:37:12PM +0000, Chris Wilson wrote:
> On Wed, Jan 23, 2013 at 05:30:46PM +0100, Daniel Vetter wrote:
> > On Wed, Jan 23, 2013 at 03:20:45PM +0000, Chris Wilson wrote:
> > > On Wed, Jan 23, 2013 at 04:16:35PM +0100, Daniel Vetter wrote:
> > > > Useful for statistics or on overflowing bug reports to keep things all
> > > > lined up.
> > > > 
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > 
> > > I should have added something like this long ago...
> > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Queued for -next, thanks for the review.
> 
> Pretty please for stable?

Moved to -fixes and added a cc: stable.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 7944d3015..9d4a2c2 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -30,6 +30,7 @@ 
 #include <linux/debugfs.h>
 #include <linux/slab.h>
 #include <linux/export.h>
+#include <generated/utsrelease.h>
 #include <drm/drmP.h>
 #include "intel_drv.h"
 #include "intel_ringbuffer.h"
@@ -690,6 +691,7 @@  static int i915_error_state(struct seq_file *m, void *unused)
 
 	seq_printf(m, "Time: %ld s %ld us\n", error->time.tv_sec,
 		   error->time.tv_usec);
+	seq_printf(m, "Kernel: " UTS_RELEASE);
 	seq_printf(m, "PCI ID: 0x%04x\n", dev->pci_device);
 	seq_printf(m, "EIR: 0x%08x\n", error->eir);
 	seq_printf(m, "IER: 0x%08x\n", error->ier);