From patchwork Fri Jan 25 20:57:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 2048431 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 200B13FDC4 for ; Fri, 25 Jan 2013 23:28:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5568E6F5A for ; Fri, 25 Jan 2013 15:28:43 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ye0-f176.google.com (mail-ye0-f176.google.com [209.85.213.176]) by gabe.freedesktop.org (Postfix) with ESMTP id B678DE6ED6 for ; Fri, 25 Jan 2013 12:58:07 -0800 (PST) Received: by mail-ye0-f176.google.com with SMTP id m1so134722yen.21 for ; Fri, 25 Jan 2013 12:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=pgEYCfJptXVNJkdHAI3QrkoVLGeaX2IlVpEamg1GsFg=; b=ev8flro67mA9Mou2ks33N9uFTWnuQb8BnHzS+hJ86FHRrlhVjA+JzJCEMF/hUT9YbE 3d0ZV7TwUFTwjYFsRQFtbyFWuxibyytcLfrdTPYPd3v7MZa4VokkEPZaOqxi5kfcXJ6p v89Y8Uye/73Sd2bK4KJyVhQ8+7bkbgYJ1Rci26wkq12mAim4Zlf6z8qBOYTeAt7XsuR6 k3Vw+N25Uqa3uklIRtfk437fD8z6yBBwaX3PyyNJbNGe6PulwEhK+p0h+uu1K8e8cwDw xDEo8HABpmJsK64tCzJxdIQruocILyvN0I6ee8LBl2+G3K64ps1nDJcPqF9D9m3S8IOq R5gw== X-Received: by 10.236.189.71 with SMTP id b47mr7585094yhn.48.1359147486887; Fri, 25 Jan 2013 12:58:06 -0800 (PST) Received: from vicky.domain.invalid ([177.42.13.174]) by mx.google.com with ESMTPS id k63sm2088659yhj.20.2013.01.25.12.58.05 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Jan 2013 12:58:06 -0800 (PST) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Fri, 25 Jan 2013 18:57:40 -0200 Message-Id: <1359147462-3902-6-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1359147462-3902-1-git-send-email-przanoni@gmail.com> References: <1359147462-3902-1-git-send-email-przanoni@gmail.com> Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH 5/7] drm/i915: WARN on unclaimed registers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org From: Paulo Zanoni While debugging these "unclaimed register" problems I concluded that having a backtrace is way much more useful than having the register address, since in a lot of cases the register address print on the message is not the register we're looking for. We must fix all the "unclaimed register" problems, so if dmesg gets too polluted it means we're too bugged. Signed-off-by: Paulo Zanoni Reviewed-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 422dfc6..bc0eb88 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1227,14 +1227,14 @@ ilk_dummy_write(struct drm_i915_private *dev_priv) #define UNCLAIMED_REG_CLEAR(dev_priv, reg, op) \ if (IS_HASWELL(dev_priv->dev) && \ (I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \ - DRM_ERROR("Unclaimed register before %x (%c)\n", reg, op); \ + WARN(1, "Unclaimed register before %x (%c)\n", reg, op); \ I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \ } #define UNCLAIMED_REG_CHECK(dev_priv, reg, op) \ if (IS_HASWELL(dev_priv->dev) && \ (I915_READ_NOTRACE(FPGA_DBG) & FPGA_DBG_RM_NOCLAIM)) { \ - DRM_ERROR("Unclaimed register %x (%c)\n", reg, op); \ + WARN(1, "Unclaimed register %x (%c)\n", reg, op); \ I915_WRITE_NOTRACE(FPGA_DBG, FPGA_DBG_RM_NOCLAIM); \ }