| Message ID | 1359415936-2732-1-git-send-email-ben@bwidawsk.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Ben Widawsky <ben@bwidawsk.net> writes: > /sys/kernel/debug has more or less been the standard location of debugfs > for several years now. Other parts of DRM already use this location, so > we should as well. > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> Reviewed-by: Carl Worth <cworth@cworth.org> -Carl
On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote: > /sys/kernel/debug has more or less been the standard location of debugfs > for several years now. Other parts of DRM already use this location, so > we should as well. > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote: > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote: > > /sys/kernel/debug has more or less been the standard location of debugfs > > for several years now. Other parts of DRM already use this location, so > > we should as well. > > > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> > > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from checkpatch.pl while applying: Applying: drm/i915: Error state should print /sys/kernel/debug WARNING: line over 80 characters #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308: + DRM_INFO("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n", total: 0 errors, 1 warnings, 8 lines checked Yeah, I've added that OCD thing to my patch apply pipeline, let's see how much fun it is ;-) -Daniel > > -- > Damien > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, 29 Jan 2013, Daniel Vetter <daniel@ffwll.ch> wrote: > Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from > checkpatch.pl while applying: > > Applying: drm/i915: Error state should print /sys/kernel/debug > WARNING: line over 80 characters > #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308: > + DRM_INFO("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n", > > total: 0 errors, 1 warnings, 8 lines checked > > Yeah, I've added that OCD thing to my patch apply pipeline, let's see > how much fun it is ;-) You could go all the way: http://lwn.net/Articles/488992/ ;) J.
On Tue, 29 Jan 2013 09:54:18 +0100 Daniel Vetter <daniel@ffwll.ch> wrote: > On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote: > > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote: > > > /sys/kernel/debug has more or less been the standard location of > > > debugfs for several years now. Other parts of DRM already use > > > this location, so we should as well. > > > > > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> > > > > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> > > Queued for -next, thanks for the patch. Oh and fixed up a bikeshed > from checkpatch.pl while applying: > > Applying: drm/i915: Error state should print /sys/kernel/debug > WARNING: line over 80 characters > #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308: > + DRM_INFO("capturing error event; look for more information > in /sys/kernel/debug/dri/%d/i915_error_state\n", > > total: 0 errors, 1 warnings, 8 lines checked > > Yeah, I've added that OCD thing to my patch apply pipeline, let's see > how much fun it is ;-) I've not looked at the final patch yet, but I think breaking up constant strings is considered bad form, and lines above 80 are generally favored for grepability. At least James Bottomley said that in his talk and LPC, and a bunch of other maintainers seemed to agree. (and I agree) > -Daniel > > > > -- > > Damien
On Tue, Jan 29, 2013 at 08:52:36AM -0800, Ben Widawsky wrote: > On Tue, 29 Jan 2013 09:54:18 +0100 > Daniel Vetter <daniel@ffwll.ch> wrote: > > > On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote: > > > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote: > > > > /sys/kernel/debug has more or less been the standard location of > > > > debugfs for several years now. Other parts of DRM already use > > > > this location, so we should as well. > > > > > > > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net> > > > > > > Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> > > > > Queued for -next, thanks for the patch. Oh and fixed up a bikeshed > > from checkpatch.pl while applying: > > > > Applying: drm/i915: Error state should print /sys/kernel/debug > > WARNING: line over 80 characters > > #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308: > > + DRM_INFO("capturing error event; look for more information > > in /sys/kernel/debug/dri/%d/i915_error_state\n", > > > > total: 0 errors, 1 warnings, 8 lines checked > > > > Yeah, I've added that OCD thing to my patch apply pipeline, let's see > > how much fun it is ;-) > > I've not looked at the final patch yet, but I think breaking up > constant strings is considered bad form, and lines above 80 are > generally favored for grepability. > > At least James Bottomley said that in his talk and LPC, and a bunch of > other maintainers seemed to agree. (and I agree) I routinely ignore the 80 cols warnings. I'm sure a significant part of my patches violate it, even the ones w/o long strings.
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 943db10..1b8d3dd 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1305,7 +1305,7 @@ static void i915_capture_error_state(struct drm_device *dev) return; } - DRM_INFO("capturing error event; look for more information in /debug/dri/%d/i915_error_state\n", + DRM_INFO("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n", dev->primary->index); kref_init(&error->ref);
/sys/kernel/debug has more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well. Signed-off-by: Ben Widawsky <ben@bwidawsk.net> --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)