diff mbox

[1/1] tests/gem_ctx_exec: fix destroy ioctl number

Message ID 1359983610-10621-1-git-send-email-mika.kuoppala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mika Kuoppala Feb. 4, 2013, 1:13 p.m. UTC 
Destroy was never called properly

Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 tests/gem_ctx_exec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Vetter Feb. 4, 2013, 4:27 p.m. UTC | #1 
On Mon, Feb 04, 2013 at 03:13:30PM +0200, Mika Kuoppala wrote:
> Destroy was never called properly
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Oops, that's a bit a goof-up, nice catch. While at it, can you please
augment the test to check whether a destroyed context doesn't work any
more for batchbuffers? It looks like gem_ctx_exec.c should be easy to
extend with this.
-Daniel

> ---
>  tests/gem_ctx_exec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> index 423f1ee..0288fe8 100644
> --- a/tests/gem_ctx_exec.c
> +++ b/tests/gem_ctx_exec.c
> @@ -57,7 +57,7 @@ struct local_drm_i915_gem_context_destroy {
>  };
>  
>  #define CONTEXT_CREATE_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2d, struct local_drm_i915_gem_context_create)
> -#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x23, struct local_drm_i915_gem_context_destroy)
> +#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2e, struct local_drm_i915_gem_context_destroy)
>  
>  static uint32_t context_create(int fd)
>  {
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
index 423f1ee..0288fe8 100644
--- a/tests/gem_ctx_exec.c
+++ b/tests/gem_ctx_exec.c
@@ -57,7 +57,7 @@  struct local_drm_i915_gem_context_destroy {
 };
 
 #define CONTEXT_CREATE_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2d, struct local_drm_i915_gem_context_create)
-#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x23, struct local_drm_i915_gem_context_destroy)
+#define CONTEXT_DESTROY_IOCTL DRM_IOWR(DRM_COMMAND_BASE + 0x2e, struct local_drm_i915_gem_context_destroy)
 
 static uint32_t context_create(int fd)
 {