| Message ID | 1361304703-2869-7-git-send-email-jbarnes@virtuousgeek.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi 2013/2/19 Jesse Barnes <jbarnes@virtuousgeek.org>: > Commented out and unneeded. Oh, "DRM: i915: add mode setting support" added it, already commented. > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > --- > drivers/gpu/drm/i915/intel_fb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c > index 987bc33..f4e0b88 100644 > --- a/drivers/gpu/drm/i915/intel_fb.c > +++ b/drivers/gpu/drm/i915/intel_fb.c > @@ -152,8 +152,6 @@ static int intelfb_create(struct intel_fbdev *ifbdev, > /* This driver doesn't need a VT switch to restore the mode on resume */ > info->skip_vt_switch = true; > > -// memset(info->screen_base, 0, size); > - > drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); > drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); > > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, Feb 19, 2013 at 06:17:09PM -0300, Paulo Zanoni wrote: > Hi > > 2013/2/19 Jesse Barnes <jbarnes@virtuousgeek.org>: > > Commented out and unneeded. > > Oh, "DRM: i915: add mode setting support" added it, already commented. > > > > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Queued for -next, thanks for the patch. I'll hold off on the other ones until it's clear what's going on on Paulo's machine. -Daniel > > > --- > > drivers/gpu/drm/i915/intel_fb.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c > > index 987bc33..f4e0b88 100644 > > --- a/drivers/gpu/drm/i915/intel_fb.c > > +++ b/drivers/gpu/drm/i915/intel_fb.c > > @@ -152,8 +152,6 @@ static int intelfb_create(struct intel_fbdev *ifbdev, > > /* This driver doesn't need a VT switch to restore the mode on resume */ > > info->skip_vt_switch = true; > > > > -// memset(info->screen_base, 0, size); > > - > > drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); > > drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); > > > > -- > > 1.7.9.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Paulo Zanoni > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c index 987bc33..f4e0b88 100644 --- a/drivers/gpu/drm/i915/intel_fb.c +++ b/drivers/gpu/drm/i915/intel_fb.c @@ -152,8 +152,6 @@ static int intelfb_create(struct intel_fbdev *ifbdev, /* This driver doesn't need a VT switch to restore the mode on resume */ info->skip_vt_switch = true; -// memset(info->screen_base, 0, size); - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height);
Commented out and unneeded. Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- drivers/gpu/drm/i915/intel_fb.c | 2 -- 1 file changed, 2 deletions(-)