diff mbox

[2/2] drm/i915: gen2 has no tv out support

Message ID 1361490785-12808-3-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Feb. 21, 2013, 11:53 p.m. UTC 
So ditch that if clause from the i8xx pll update code.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Paulo Zanoni Feb. 25, 2013, 8:01 p.m. UTC | #1 
Hi

2013/2/21 Daniel Vetter <daniel.vetter@ffwll.ch>:
> So ditch that if clause from the i8xx pll update code.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ebe9dae..b521198 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4521,11 +4521,7 @@ static void i8xx_update_pll(struct drm_crtc *crtc,
>                         dpll |= PLL_P2_DIVIDE_BY_4;
>         }
>
> -       if (intel_pipe_has_type(crtc, INTEL_OUTPUT_TVOUT))
> -               /* XXX: just matching BIOS for now */
> -               /*      dpll |= PLL_REF_INPUT_TVCLKINBC; */
> -               dpll |= 3;
> -       else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
> +       if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
>                  intel_panel_use_ssc(dev_priv) && num_connectors < 2)
>                 dpll |= PLLB_REF_INPUT_SPREADSPECTRUMIN;
>         else
> --
> 1.7.11.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ebe9dae..b521198 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4521,11 +4521,7 @@  static void i8xx_update_pll(struct drm_crtc *crtc,
 			dpll |= PLL_P2_DIVIDE_BY_4;
 	}
 
-	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_TVOUT))
-		/* XXX: just matching BIOS for now */
-		/*	dpll |= PLL_REF_INPUT_TVCLKINBC; */
-		dpll |= 3;
-	else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
+	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
 		 intel_panel_use_ssc(dev_priv) && num_connectors < 2)
 		dpll |= PLLB_REF_INPUT_SPREADSPECTRUMIN;
 	else