diff mbox

[I-G-T] tools/intel_reg_dumper: add hsw backlight registers

Message ID 1362392530-10589-1-git-send-email-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jani Nikula March 4, 2013, 10:22 a.m. UTC 
The more the merrier.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 lib/intel_reg.h          |    5 +++++
 tools/intel_reg_dumper.c |    5 +++++
 2 files changed, 10 insertions(+)

Comments

Paul Menzel March 4, 2013, 11:09 a.m. UTC | #1 
Dear intel-gfx folks,


Am Montag, den 04.03.2013, 12:22 +0200 schrieb Jani Nikula:
> The more the merrier.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  lib/intel_reg.h          |    5 +++++
>  tools/intel_reg_dumper.c |    5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/lib/intel_reg.h b/lib/intel_reg.h
> index 99d97bb..db07064 100644
> --- a/lib/intel_reg.h
> +++ b/lib/intel_reg.h
> @@ -3465,6 +3465,11 @@ typedef enum {
>  #define  PWM_PIPE_B             (1 << 29)
>  #define BLC_PWM_CPU_CTL         0x48254
>  
> +#define BLC_PWM2_CTL		0x48350
> +#define BLC_PWM2_DATA		0x48354
> +#define BLC_MISC_CTL		0x48360
> +#define UTIL_PIN_CTL		0x48400
> +

looking at that change I noticed that tabs and spaces are mixed in that
file? What is preferred?

>  #define BLC_PWM_PCH_CTL1        0xc8250
>  #define  PWM_PCH_ENABLE         (1 << 31)
>  #define  PWM_POLARITY_ACTIVE_LOW        (1 << 29)

[…]


Thanks,

Paul
diff mbox

Patch

diff --git a/lib/intel_reg.h b/lib/intel_reg.h
index 99d97bb..db07064 100644
--- a/lib/intel_reg.h
+++ b/lib/intel_reg.h
@@ -3465,6 +3465,11 @@  typedef enum {
 #define  PWM_PIPE_B             (1 << 29)
 #define BLC_PWM_CPU_CTL         0x48254
 
+#define BLC_PWM2_CTL		0x48350
+#define BLC_PWM2_DATA		0x48354
+#define BLC_MISC_CTL		0x48360
+#define UTIL_PIN_CTL		0x48400
+
 #define BLC_PWM_PCH_CTL1        0xc8250
 #define  PWM_PCH_ENABLE         (1 << 31)
 #define  PWM_POLARITY_ACTIVE_LOW        (1 << 29)
diff --git a/tools/intel_reg_dumper.c b/tools/intel_reg_dumper.c
index 20f332f..9f22720 100644
--- a/tools/intel_reg_dumper.c
+++ b/tools/intel_reg_dumper.c
@@ -1899,6 +1899,11 @@  static struct reg_debug haswell_debug_regs[] = {
 	/* Fuses */
 	DEFINEREG(SFUSE_STRAP),
 
+	/* Backlight */
+	DEFINEREG(BLC_PWM2_CTL),
+	DEFINEREG(BLC_PWM2_DATA),
+	DEFINEREG(BLC_MISC_CTL),
+	DEFINEREG(UTIL_PIN_CTL),
 };
 
 static struct reg_debug i945gm_mi_regs[] = {