| Message ID | 1364340792-7278-9-git-send-email-jbarnes@virtuousgeek.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 26, 2013 at 04:33:11PM -0700, Jesse Barnes wrote: > In case we don't get an fb from the BIOS, we may still be able to re-use > existing state and flip a new buffer. > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> This hack here smells extremely fishy. Where do we come up with no fb, but a real mode and want to actually fastboot? -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 0f3c036..f24da1a 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8109,10 +8109,8 @@ intel_set_config_compute_mode_changes(struct drm_mode_set *set, > /* We should be able to check here if the fb has the same properties > * and then just flip_or_move it */ > if (set->crtc->fb != set->fb) { > - /* If we have no fb then treat it as a full mode set */ > if (set->crtc->fb == NULL) { > - DRM_DEBUG_KMS("crtc has no fb, full mode set\n"); > - config->mode_changed = true; > + config->fb_changed = true; > } else if (set->fb == NULL) { > config->mode_changed = true; > } else if (set->fb->depth != set->crtc->fb->depth) { > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 0f3c036..f24da1a 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -8109,10 +8109,8 @@ intel_set_config_compute_mode_changes(struct drm_mode_set *set, /* We should be able to check here if the fb has the same properties * and then just flip_or_move it */ if (set->crtc->fb != set->fb) { - /* If we have no fb then treat it as a full mode set */ if (set->crtc->fb == NULL) { - DRM_DEBUG_KMS("crtc has no fb, full mode set\n"); - config->mode_changed = true; + config->fb_changed = true; } else if (set->fb == NULL) { config->mode_changed = true; } else if (set->fb->depth != set->crtc->fb->depth) {
In case we don't get an fb from the BIOS, we may still be able to re-use existing state and flip a new buffer. Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> --- drivers/gpu/drm/i915/intel_display.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)