From patchwork Sat Apr 6 21:54:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 2402471 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 641ACDFB7B for ; Sat, 6 Apr 2013 21:52:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12273E5CBF for ; Sat, 6 Apr 2013 14:52:10 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 08463E5C7E for ; Sat, 6 Apr 2013 14:52:00 -0700 (PDT) Received: by mail-ee0-f45.google.com with SMTP id c50so1015616eek.4 for ; Sat, 06 Apr 2013 14:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=EdiQ6Je2KlDPX7XpNRaZbfRQm0SBoKiUSnACd8eLOM0=; b=H9CWkG5G9TpdI8vOkGsBCYY89K0igZIxcW7w/E+mM1/SGP87vC9VjP80DtZ5s87wa3 07udkSKfC30z3kfm8T2srjF0hA2CCptuIcISA1q8ZeVyacog93DWIpEK6QkLoLZKXkbB N9BpQk9uqVSmiidil5bvnBLSJK9fPCLJ+0jpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding :x-gm-message-state; bh=EdiQ6Je2KlDPX7XpNRaZbfRQm0SBoKiUSnACd8eLOM0=; b=dsQC/UsWHKgC/CFbz4qnQ2xyFKaXsn7JKVyh2dve+y6+bHk2T4PyajRVnh/Ss59hCY 5xWBPG5ZhwgpbIXoHGCcx7s8jl50izmLcXpMq0gsNXAF6Atollg/VFvhpCy8U2SRnkmL hGnqzf+m/OLO5CN8ubYG+voZmtoRlHYkwmlFgMDX61Xb5NLxDM8iDZv+xkMzSyWe7UiC IqfIklhBHFxXyF4wHSMQGMV+KpdSht/H4UaU3RvVfL8RRqPzi6RvVR7UW2EgQAwWn+Ds ctxHZkelMALYbB/0iDstRRlAARNs9AEEblpEqeYDYHpKIUj42UkR0IsrmZJkvvK6tm1n 6LgA== X-Received: by 10.15.61.8 with SMTP id h8mr32870393eex.33.1365285119935; Sat, 06 Apr 2013 14:51:59 -0700 (PDT) Received: from phenom.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPS id f47sm23098822eep.13.2013.04.06.14.51.58 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 06 Apr 2013 14:51:59 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Sat, 6 Apr 2013 23:54:56 +0200 Message-Id: <1365285296-10721-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1365091988-21213-1-git-send-email-daniel.vetter@ffwll.ch> References: <1365091988-21213-1-git-send-email-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmfcBCQB8OLn6YdNdtN1wDmHoR8c+SgoSjbsiSgh6yYcWo0QKCgas1tQaL6p2ddbow5rUBB Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH] drm/i915: tune down Y tiling scanout warning X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Userspace can easily hit this and does since Ville added a new evil igt testcase in: commit 069e35e0fc3785faa562adcfd2dd7bbed4cb1dea Author: Ville Syrjälä Date: Mon Mar 4 15:34:06 2013 +0200 kms_flip: Add flip-vs-bad-tiling test v2: Fix the spelling in the added comment (Chris). Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 1b2c744..0e799ea 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -1907,8 +1907,10 @@ intel_pin_and_fence_fb_obj(struct drm_device *dev, alignment = 0; break; case I915_TILING_Y: - /* FIXME: Is this true? */ - DRM_ERROR("Y tiled not allowed for scan out buffers\n"); + /* Despite that we check this in framebuffer_init userspace can + * screw us over and change the tiling after the fact. Only + * pinned buffers can't change their tiling. */ + DRM_DEBUG_DRIVER("Y tiled not allowed for scan out buffers\n"); return -EINVAL; default: BUG();