diff mbox

drm/i915: update FDI mPHY setup code

Message ID 1365414740-5173-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter April 8, 2013, 9:52 a.m. UTC
Bspec has been been updated and dropped these two changes for non-sdv
LPT PCHs.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |    7 -------
 1 file changed, 7 deletions(-)

Comments

Paulo Zanoni April 8, 2013, 2:42 p.m. UTC | #1
Hi

2013/4/8 Daniel Vetter <daniel.vetter@ffwll.ch>:
> Bspec has been been updated and dropped these two changes for non-sdv
> LPT PCHs.
>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c |    7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 04d91cc..8809813 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4958,13 +4958,6 @@ static void lpt_init_pch_refclk(struct drm_device *dev)
>         tmp |= (0x12 << 24);
>         intel_sbi_write(dev_priv, 0x8008, tmp, SBI_MPHY);
>
> -       if (!is_sdv) {
> -               tmp = intel_sbi_read(dev_priv, 0x808C, SBI_MPHY);
> -               tmp &= ~(0x3 << 6);
> -               tmp |= (1 << 6) | (1 << 0);
> -               intel_sbi_write(dev_priv, 0x808C, tmp, SBI_MPHY);
> -       }
> -
>         if (is_sdv) {
>                 tmp = intel_sbi_read(dev_priv, 0x800C, SBI_MPHY);
>                 tmp |= 0x7FFF;
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



--
Paulo Zanoni
Daniel Vetter April 8, 2013, 3:10 p.m. UTC | #2
On Mon, Apr 08, 2013 at 11:42:21AM -0300, Paulo Zanoni wrote:
> Hi
> 
> 2013/4/8 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Bspec has been been updated and dropped these two changes for non-sdv
> > LPT PCHs.
> >
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the review.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 04d91cc..8809813 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4958,13 +4958,6 @@  static void lpt_init_pch_refclk(struct drm_device *dev)
 	tmp |= (0x12 << 24);
 	intel_sbi_write(dev_priv, 0x8008, tmp, SBI_MPHY);
 
-	if (!is_sdv) {
-		tmp = intel_sbi_read(dev_priv, 0x808C, SBI_MPHY);
-		tmp &= ~(0x3 << 6);
-		tmp |= (1 << 6) | (1 << 0);
-		intel_sbi_write(dev_priv, 0x808C, tmp, SBI_MPHY);
-	}
-
 	if (is_sdv) {
 		tmp = intel_sbi_read(dev_priv, 0x800C, SBI_MPHY);
 		tmp |= 0x7FFF;