diff mbox

drm/i915: fix panel fitting on LVDS on ILK+ v2

Message ID 1367612797-10906-1-git-send-email-jbarnes@virtuousgeek.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jesse Barnes May 3, 2013, 8:26 p.m. UTC
This regression was introduced in:

commit b074cec8c652f2d273907a4b35239b4766c894ac
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Apr 25 12:55:02 2013 -0700

    drm/i915: move PCH pfit controls into pipe_config

In refactoring this, it was only applied to eDP, which is incorrect.  In
fact, if we ever use the panel fitter to deal with overscan on HDMI,
we'll need to extend it again, so just drop the conditional altogether.

v2: drop check for eDP since we can use the fitter in any config (Daniel)

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Daniel Vetter May 6, 2013, 4:59 p.m. UTC | #1
On Fri, May 03, 2013 at 01:26:37PM -0700, Jesse Barnes wrote:
> This regression was introduced in:
> 
> commit b074cec8c652f2d273907a4b35239b4766c894ac
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date:   Thu Apr 25 12:55:02 2013 -0700
> 
>     drm/i915: move PCH pfit controls into pipe_config
> 
> In refactoring this, it was only applied to eDP, which is incorrect.  In
> fact, if we ever use the panel fitter to deal with overscan on HDMI,
> we'll need to extend it again, so just drop the conditional altogether.
> 
> v2: drop check for eDP since we can use the fitter in any config (Daniel)
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Queued for -next, thanks for the patch.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index aa99b4d..7b4005b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3239,8 +3239,7 @@  static void ironlake_pfit_enable(struct intel_crtc *crtc)
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	int pipe = crtc->pipe;
 
-	if (crtc->config.pch_pfit.size &&
-	    intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_EDP)) {
+	if (crtc->config.pch_pfit.size) {
 		/* Force use of hard-coded filter coefficients
 		 * as some pre-programmed values are broken,
 		 * e.g. x201.