diff mbox

[3/6] drm/i915: ilk-ivb: replace is_pch_edp() with port==PORT_D

Message ID 1367940253-10329-4-git-send-email-imre.deak@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Imre Deak May 7, 2013, 3:24 p.m. UTC
On ILK-IVB the PCH side eDP is always on port-D.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Vetter May 7, 2013, 3:35 p.m. UTC | #1
On Tue, May 7, 2013 at 5:24 PM, Imre Deak <imre.deak@intel.com> wrote:
> On ILK-IVB the PCH side eDP is always on port-D.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 5b689b2..bdf07b7 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5067,7 +5067,7 @@ static void ironlake_init_pch_refclk(struct drm_device *dev)
>                         break;
>                 case INTEL_OUTPUT_EDP:
>                         has_panel = true;
> -                       if (intel_encoder_is_pch_edp(&encoder->base))
> +                       if (enc_to_dig_port(&encoder->base)->port == PORT_D)
>                                 has_pch_edp = true;
>                         else
>                                 has_cpu_edp = true;

The only place we use that is for a debug output. Imo it's better to
kill this here and move any relevant debug output to intel_dp_init (if
there's anything missing).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 5b689b2..bdf07b7 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5067,7 +5067,7 @@  static void ironlake_init_pch_refclk(struct drm_device *dev)
 			break;
 		case INTEL_OUTPUT_EDP:
 			has_panel = true;
-			if (intel_encoder_is_pch_edp(&encoder->base))
+			if (enc_to_dig_port(&encoder->base)->port == PORT_D)
 				has_pch_edp = true;
 			else
 				has_cpu_edp = true;