diff mbox

[3/4] drm/i915: VLV support is no longer preliminary

Message ID 1368035116-3345-3-git-send-email-jbarnes@virtuousgeek.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jesse Barnes May 8, 2013, 5:45 p.m. UTC
Works pretty well actually.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/i915_drv.c |    6 ------
 1 file changed, 6 deletions(-)

Comments

Daniel Vetter May 10, 2013, 7:29 a.m. UTC | #1
On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> Works pretty well actually.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Patches 1-3 merged to dinq, thanks. I'm a bit unhappy that we don't have
mipi yet, otoh mipi needs sink drivers so meh.
-Daniel
Jesse Barnes May 10, 2013, 4:10 p.m. UTC | #2
On Fri, 10 May 2013 09:29:28 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> > Works pretty well actually.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Patches 1-3 merged to dinq, thanks. I'm a bit unhappy that we don't have
> mipi yet, otoh mipi needs sink drivers so meh.

Yeah, MIPI DSI is a bit messy regardless, so I think it's ok to call it
"ready" even if we don't have some specific DSI panels supported.
Daniel Vetter May 10, 2013, 6:58 p.m. UTC | #3
On Fri, May 10, 2013 at 09:10:27AM -0700, Jesse Barnes wrote:
> On Fri, 10 May 2013 09:29:28 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> > > Works pretty well actually.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > Patches 1-3 merged to dinq, thanks. I'm a bit unhappy that we don't have
> > mipi yet, otoh mipi needs sink drivers so meh.
> 
> Yeah, MIPI DSI is a bit messy regardless, so I think it's ok to call it
> "ready" even if we don't have some specific DSI panels supported.

Another thing which looked _really_ fishy was non-eDP DP support on vlv.
Atm we often only take the new vlv dp paths due to is_cpu_edp being true
on vlv edp, too. Imo that should be remedied and we should move all the
vlv paths out of the is_cpu_edp checks (and maybe inline the port ==
PORT_A check for ilk-ivb in all relevant places). Imre has ideas already,
too.
-Daniel
Jesse Barnes May 10, 2013, 7:09 p.m. UTC | #4
On Fri, 10 May 2013 20:58:17 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Fri, May 10, 2013 at 09:10:27AM -0700, Jesse Barnes wrote:
> > On Fri, 10 May 2013 09:29:28 +0200
> > Daniel Vetter <daniel@ffwll.ch> wrote:
> > 
> > > On Wed, May 08, 2013 at 10:45:15AM -0700, Jesse Barnes wrote:
> > > > Works pretty well actually.
> > > > 
> > > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > 
> > > Patches 1-3 merged to dinq, thanks. I'm a bit unhappy that we don't have
> > > mipi yet, otoh mipi needs sink drivers so meh.
> > 
> > Yeah, MIPI DSI is a bit messy regardless, so I think it's ok to call it
> > "ready" even if we don't have some specific DSI panels supported.
> 
> Another thing which looked _really_ fishy was non-eDP DP support on vlv.
> Atm we often only take the new vlv dp paths due to is_cpu_edp being true
> on vlv edp, too. Imo that should be remedied and we should move all the
> vlv paths out of the is_cpu_edp checks (and maybe inline the port ==
> PORT_A check for ilk-ivb in all relevant places). Imre has ideas already,
> too.

Ok just be careful, because regular DP works fine here in testing. :)
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 624cdfc..e57b127 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -964,12 +964,6 @@  static int i915_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	struct intel_device_info *intel_info =
 		(struct intel_device_info *) ent->driver_data;
 
-	if (intel_info->is_valleyview)
-		if(!i915_preliminary_hw_support) {
-			DRM_ERROR("Preliminary hardware support disabled\n");
-			return -ENODEV;
-		}
-
 	/* Only bind to function 0 of the device. Early generations
 	 * used function 1 as a placeholder for multi-head. This causes
 	 * us confusion instead, especially on the systems where both