| Message ID | 1370358801-305-1-git-send-email-eich@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote: > In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used > for DDC. Thus the code will always have to rely on a LVDS panel > mode supplied by VBT. > In most cases this succeeds, so this didn't get detected for quite > a while. > > Signed-off-by: Egbert Eich <eich@suse.de> Good catch! Cc: stable@vger.kernel.org Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On Tue, Jun 04, 2013 at 04:35:32PM +0100, Chris Wilson wrote: > On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote: > > In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used > > for DDC. Thus the code will always have to rely on a LVDS panel > > mode supplied by VBT. > > In most cases this succeeds, so this didn't get detected for quite > > a while. > > > > Signed-off-by: Egbert Eich <eich@suse.de> > > Good catch! > Cc: stable@vger.kernel.org > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Yeah, nice catch. If my history digging is correct this has been broken in commit f899fc64cda8569d0529452aafc0da31c042df2e Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Jul 20 15:44:45 2010 -0700 drm/i915: use GMBUS to manage i2c links Patch merged with that note added, thanks. -Daniel > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 7068195..8618b15 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c @@ -1848,7 +1848,7 @@ static void intel_sdvo_get_lvds_modes(struct drm_connector *connector) * Assume that the preferred modes are * arranged in priority order. */ - intel_ddc_get_modes(connector, intel_sdvo->i2c); + intel_ddc_get_modes(connector, &intel_sdvo->ddc); if (list_empty(&connector->probed_modes) == false) goto end;
In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used for DDC. Thus the code will always have to rely on a LVDS panel mode supplied by VBT. In most cases this succeeds, so this didn't get detected for quite a while. Signed-off-by: Egbert Eich <eich@suse.de> --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)