From patchwork Tue Jul 23 22:33:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 2832302 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 68E43C0319 for ; Tue, 23 Jul 2013 22:40:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A4AFD20435 for ; Tue, 23 Jul 2013 22:40:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C4D4F20434 for ; Tue, 23 Jul 2013 22:40:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5CDAE6796 for ; Tue, 23 Jul 2013 15:40:35 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ye0-f180.google.com (mail-ye0-f180.google.com [209.85.213.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 92169E66EA for ; Tue, 23 Jul 2013 15:35:02 -0700 (PDT) Received: by mail-ye0-f180.google.com with SMTP id q4so1105075yen.25 for ; Tue, 23 Jul 2013 15:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=cDhtb6fAQjjRzzroEOJkdU1R6Kw6DJFTrN8Bx8/sxeE=; b=TtE9ajIW9qKtKpQbXrsHHbWC0oLJEfciHF3WVp0vidzIsFVA1pOC4jSzqE0Acd/ruf w2ciBMrZ+Ibz1BmOmLXIC77XoR2SNL6Bhs/2V/WgAcKrPdAZtgeFrOsxQu+m500Un3rr tStDygsf8bjRMUORaydmz9U2tOXTUhL90vB5xGPx2lY78fzKqjxUgMdHEMqC6wIt0sAS XlrzJ1M+KLKgF1G6+1IWx4nkARcdvAEE8ZatMkLEne1yhr1V4XR3AbPb6ziVouvYYmr/ GErku85AQFUiH6lYB5qmph7B2/ArvA4bfKVTHDZ3lDpjg8v979ouIgI/SKEGNOBZzRtK CVcg== X-Received: by 10.236.154.37 with SMTP id g25mr16483174yhk.216.1374618902182; Tue, 23 Jul 2013 15:35:02 -0700 (PDT) Received: from localhost.localdomain ([177.16.164.57]) by mx.google.com with ESMTPSA id m63sm48420675yhb.10.2013.07.23.15.35.00 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Jul 2013 15:35:01 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Tue, 23 Jul 2013 19:33:49 -0300 Message-Id: <1374618835-28120-10-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1374618835-28120-1-git-send-email-przanoni@gmail.com> References: <1374618835-28120-1-git-send-email-przanoni@gmail.com> Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH 09/15] drm/i915: remove additional zerogin of VLV_IIR at postinstall X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni There is no comment explaining why it's needed and I don't see a reason for it to exist. Also, a few lines above we call INTEL_IRQ_REG_INIT and pass VLV_IIR, so we should print a WARN in case VLV_IIR is not zero at that point. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 6793b30..5ca50a0 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2244,9 +2244,6 @@ static int valleyview_irq_postinstall(struct drm_device *dev) i915_enable_pipestat(dev_priv, 1, pipestat_enable); spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags); - I915_WRITE(VLV_IIR, 0xffffffff); - I915_WRITE(VLV_IIR, 0xffffffff); - gen5_gt_irq_postinstall(dev); /* ack & enable invalid PTE error interrupts */