From patchwork Tue Jul 23 22:33:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 2832304 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0E766C0319 for ; Tue, 23 Jul 2013 22:41:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3E8052043C for ; Tue, 23 Jul 2013 22:41:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 6DF8D20438 for ; Tue, 23 Jul 2013 22:41:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A4FBE67D7 for ; Tue, 23 Jul 2013 15:41:02 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-yh0-f44.google.com (mail-yh0-f44.google.com [209.85.213.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 36C51E676F for ; Tue, 23 Jul 2013 15:35:04 -0700 (PDT) Received: by mail-yh0-f44.google.com with SMTP id t59so3118785yho.17 for ; Tue, 23 Jul 2013 15:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=V5jiCbpuQzZDpf+YNcP19XXRcPFPRwoFnxP3pUz0TQY=; b=ppaecCkCd9pK+seRnKGcIANPNEqGp+3brQ5HmVwXEmoz2W/eX/ei0kXQ1MqPwEH1UI yAdmzfxaVBexGVs29/HHxJz6Aoy704M42JMJ18XriqrZ09fNt3E1XdTMq1CQ3XkV7K4p kmO4lOI2r+yQ3vhhttOfOynaLTdibR+GyX58YRYzUxpkY7Kg9hvh5rMT6gVyXYCSTqDg fyu5bjWYgE8oVx1GXYPCIjMKlomaYexu1qQ2+ABgZHge6Yk+Nf7VWWKpjmzKCDowjt1V cnfLK9o6i7hskKLesW2cFwDwbC+CukkJ39RQM/xErqRnBMNNSCGZcgc9M2oEY4Qf9/nI LkYQ== X-Received: by 10.236.47.40 with SMTP id s28mr16197471yhb.12.1374618903623; Tue, 23 Jul 2013 15:35:03 -0700 (PDT) Received: from localhost.localdomain ([177.16.164.57]) by mx.google.com with ESMTPSA id m63sm48420675yhb.10.2013.07.23.15.35.02 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Jul 2013 15:35:03 -0700 (PDT) From: Paulo Zanoni To: intel-gfx@lists.freedesktop.org Date: Tue, 23 Jul 2013 19:33:50 -0300 Message-Id: <1374618835-28120-11-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1374618835-28120-1-git-send-email-przanoni@gmail.com> References: <1374618835-28120-1-git-send-email-przanoni@gmail.com> Cc: Paulo Zanoni Subject: [Intel-gfx] [PATCH 10/15] drm/i915: remove extra clearing of GTIIR from VLV irq preinstall X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paulo Zanoni After the last changes, gen5_gt_irq_preinstall should now guarantee that GTIIR will be zero. Also, at valleyview_irq_postinstall we call gen5_gt_irq_postinstall which calls intel_irq_reg_init, which will print a nice WARN in case GTIIR is not zero. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_irq.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 5ca50a0..9684f1e 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -2056,10 +2056,6 @@ static void valleyview_irq_preinstall(struct drm_device *dev) I915_WRITE(RING_IMR(GEN6_BSD_RING_BASE), 0); I915_WRITE(RING_IMR(BLT_RING_BASE), 0); - /* and GT */ - I915_WRITE(GTIIR, I915_READ(GTIIR)); - I915_WRITE(GTIIR, I915_READ(GTIIR)); - gen5_gt_irq_preinstall(dev); I915_WRITE(DPINVGTT, 0xff);