From patchwork Mon Aug 19 23:20:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Widawsky X-Patchwork-Id: 2846731 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 129F2BF546 for ; Mon, 19 Aug 2013 23:21:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E011E20381 for ; Mon, 19 Aug 2013 23:21:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D12002021A for ; Mon, 19 Aug 2013 23:21:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0AA4E61BC for ; Mon, 19 Aug 2013 16:21:30 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 44AE1E66A7 for ; Mon, 19 Aug 2013 16:20:41 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 19 Aug 2013 16:17:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,915,1367996400"; d="scan'208";a="389800910" Received: from kumite.jf.intel.com (HELO bolo_yeung.jf.intel.com) ([10.7.199.89]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2013 16:20:40 -0700 From: Ben Widawsky To: Intel GFX Date: Mon, 19 Aug 2013 16:20:40 -0700 Message-Id: <1376954440-26434-1-git-send-email-benjamin.widawsky@intel.com> X-Mailer: git-send-email 1.8.3.4 Cc: Ben Widawsky , Ben Widawsky Subject: [Intel-gfx] [PATCH] drm/Kconfig: favor n for DRM_I915_PRELIMINARY_HW_SUPPORT X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We generally don't want people or distros to use this option unless they know what they're doing. I missed the initial conversation but it's likely a way for people who have a built-in i915.ko and have no other way to change the behavior. As such: Set default to n Display message for what users should select (N) and while there, a small whitespace fix. Cc Josh Triplett Signed-off-by: Ben Widawsky --- drivers/gpu/drm/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 62a06c7..ad4e369 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -171,12 +171,15 @@ config DRM_I915_KMS config DRM_I915_PRELIMINARY_HW_SUPPORT bool "Enable preliminary support for prerelease Intel hardware by default" depends on DRM_I915 + default n help Choose this option if you have prerelease Intel hardware and want the - i915 driver to support it by default. You can enable such support at + i915 driver to support it by default. You can enable such support at runtime with the module option i915.preliminary_hw_support=1; this option changes the default for that module option. + If in doubt, say "N". + config DRM_MGA tristate "Matrox g200/g400" depends on DRM && PCI