diff mbox

[3/3] drm/i915/vma: Remove VMA from exec_list on destroy

Message ID 1376979255-17887-3-git-send-email-benjamin.widawsky@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ben Widawsky Aug. 20, 2013, 6:14 a.m. UTC 
In order to avoid confusion, and corruption as observed (in code review)
by Chris - remove the VMA from the exec_list at destroy.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
 drivers/gpu/drm/i915/i915_gem.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Aug. 20, 2013, 8:01 a.m. UTC | #1 
On Mon, Aug 19, 2013 at 11:14:15PM -0700, Ben Widawsky wrote:
> In order to avoid confusion, and corruption as observed (in code review)
> by Chris - remove the VMA from the exec_list at destroy.

This should be BUG_ON(!list_empty(&vma->exec_list));
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 6d2d7df..9f03f5d 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4160,6 +4160,7 @@  void i915_gem_vma_destroy(struct i915_vma *vma)
 		return;
 
 	WARN_ON(vma->node.allocated);
+	list_del(&vma->exec_list);
 	list_del(&vma->vma_link);
 	kfree(vma);
 }