| Message ID | 1377283657-20808-1-git-send-email-imre.deak@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2013/8/23 Imre Deak <imre.deak@intel.com>: > Fix the typo introduced in > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85 > Author: Keith Packard <keithp@keithp.com> > Date: Wed Nov 16 16:26:07 2011 -0800 > > drm/i915: Hook up Ivybridge eDP > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880 > Tested-by: Jeremy Moles <cubicool@gmail.com> > Signed-off-by: Imre Deak <imre.deak@intel.com> Nice catch! Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 2b96d6b..019fd1f 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -4525,7 +4525,7 @@ > #define EDP_LINK_TRAIN_600MV_0DB_IVB (0x30 <<22) > #define EDP_LINK_TRAIN_600MV_3_5DB_IVB (0x36 <<22) > #define EDP_LINK_TRAIN_800MV_0DB_IVB (0x38 <<22) > -#define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x33 <<22) > +#define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x3e <<22) > > /* legacy values */ > #define EDP_LINK_TRAIN_500MV_0DB_IVB (0x00 <<22) > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote: > 2013/8/23 Imre Deak <imre.deak@intel.com>: > > Fix the typo introduced in > > > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85 > > Author: Keith Packard <keithp@keithp.com> > > Date: Wed Nov 16 16:26:07 2011 -0800 > > > > drm/i915: Hook up Ivybridge eDP > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880 > > Tested-by: Jeremy Moles <cubicool@gmail.com> > > Signed-off-by: Imre Deak <imre.deak@intel.com> > > Nice catch! > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Queued for -next, thanks for the patch. -Daniel
On Fri, Aug 23, 2013 at 10:01:27PM +0200, Daniel Vetter wrote: > On Fri, Aug 23, 2013 at 04:01:17PM -0300, Paulo Zanoni wrote: > > 2013/8/23 Imre Deak <imre.deak@intel.com>: > > > Fix the typo introduced in > > > > > > commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85 > > > Author: Keith Packard <keithp@keithp.com> > > > Date: Wed Nov 16 16:26:07 2011 -0800 > > > > > > drm/i915: Hook up Ivybridge eDP > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880 > > > Tested-by: Jeremy Moles <cubicool@gmail.com> > > > Signed-off-by: Imre Deak <imre.deak@intel.com> > > > > Nice catch! > > > > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Queued for -next, thanks for the patch. Ok, dropped again since Paulo told me on irc that we fail link training without this and so this is a black screen fix and so should go to -fixes with cc: stable. Grumpy maintainer note: Stuff like this _really_ must be part of the commit message. A headline of "fix typo in ..." plus no mention of any further impact than the fixed type for a black screen bug in the commit message is seriously misleading. Also this should imo be caught in review (since Paulo obviously knew what's going on). Please resend. Thanks, Daniel
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 2b96d6b..019fd1f 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -4525,7 +4525,7 @@ #define EDP_LINK_TRAIN_600MV_0DB_IVB (0x30 <<22) #define EDP_LINK_TRAIN_600MV_3_5DB_IVB (0x36 <<22) #define EDP_LINK_TRAIN_800MV_0DB_IVB (0x38 <<22) -#define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x33 <<22) +#define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x3e <<22) /* legacy values */ #define EDP_LINK_TRAIN_500MV_0DB_IVB (0x00 <<22)
Fix the typo introduced in commit 1a2eb4604b85c5efb343da8a4dcf41288fcfca85 Author: Keith Packard <keithp@keithp.com> Date: Wed Nov 16 16:26:07 2011 -0800 drm/i915: Hook up Ivybridge eDP Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64880 Tested-by: Jeremy Moles <cubicool@gmail.com> Signed-off-by: Imre Deak <imre.deak@intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)