diff mbox

lib/drmtest: skip suspend tests in simulation

Message ID 1378987350-3923-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Sept. 12, 2013, 12:02 p.m. UTC
The simulator doesn't like this nor really support it :(

Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 lib/drmtest.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lespiau, Damien Sept. 12, 2013, 12:30 p.m. UTC | #1
On Thu, Sep 12, 2013 at 02:02:30PM +0200, Daniel Vetter wrote:
> The simulator doesn't like this nor really support it :(
> 
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Aye! (I recall we don't really need that for i-g-t, but can't hurt)

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Daniel Vetter Sept. 12, 2013, 12:51 p.m. UTC | #2
On Thu, Sep 12, 2013 at 2:30 PM, Damien Lespiau
<damien.lespiau@intel.com> wrote:
> On Thu, Sep 12, 2013 at 02:02:30PM +0200, Daniel Vetter wrote:
>> The simulator doesn't like this nor really support it :(
>>
>> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Damien Lespiau <damien.lespiau@intel.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Aye! (I recall we don't really need that for i-g-t, but can't hurt)
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Actually on second thought we should try to at least run our driver
suspend/resume code a bit, maybe using the pm debug stuff in sysfs,
i.e.

echo devices > /sys/power/pm_test
echo mem > /sys/power/state

That should avoid any issues due to the platform being bonghits. And
we could use it even on really early SDVs when the firmware code isn't
stable yet (or other drivers not yet up to the task).

Comments?
-Daniel
diff mbox

Patch

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 9d4c5da..509db13 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -2088,6 +2088,8 @@  void igt_system_suspend_autoresume(void)
 {
 	int ret;
 
+	igt_skip_on_simulation();
+
 	ret = system("rtcwake -s 30 -m mem");
 	igt_assert(ret == 0);
 }