| Message ID | 1379678731-31098-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 20, 2013 at 03:05:30PM +0300, Jani Nikula wrote: > There is plenty of evidence suggesting all of the GM45 based Acer > laptops (including their eMachines and Packard Bell brands) use inverted > backlight PWM. Assume this is really the case, and quirk them all. > > The old bugs that were fixed by subsystem device specific quirks: > * https://bugs.freedesktop.org/show_bug.cgi?id=59628 > * https://bugzilla.kernel.org/show_bug.cgi?id=31522#c35 > * https://bugs.freedesktop.org/show_bug.cgi?id=44156 > * https://bugzilla.kernel.org/show_bug.cgi?id=53881 > > See also this bug and the plethora of duplicates: > * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/765438 > > References: https://bugzilla.kernel.org/show_bug.cgi?id=54171 > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Queued for -next, thanks for the patch. I don't really want to rock the boat by pushing this to -fixes. -Daniel
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8206ee7..5f833f8 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -10194,20 +10194,11 @@ static struct intel_quirk intel_quirks[] = { /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, - /* Acer Aspire 5734Z must invert backlight brightness */ - { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness }, - - /* Acer/eMachines G725 */ - { 0x2a42, 0x1025, 0x0210, quirk_invert_brightness }, - - /* Acer/eMachines e725 */ - { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness }, - - /* Acer/Packard Bell NCL20 */ - { 0x2a42, 0x1025, 0x034b, quirk_invert_brightness }, - - /* Acer Aspire 4736Z */ - { 0x2a42, 0x1025, 0x0260, quirk_invert_brightness }, + /* + * All GM45 Acer (and its brands eMachines and Packard Bell) laptops + * seem to use inverted backlight PWM. + */ + { 0x2a42, 0x1025, PCI_ANY_ID, quirk_invert_brightness }, /* Dell XPS13 HD Sandy Bridge */ { 0x0116, 0x1028, 0x052e, quirk_no_pcm_pwm_enable },
There is plenty of evidence suggesting all of the GM45 based Acer laptops (including their eMachines and Packard Bell brands) use inverted backlight PWM. Assume this is really the case, and quirk them all. The old bugs that were fixed by subsystem device specific quirks: * https://bugs.freedesktop.org/show_bug.cgi?id=59628 * https://bugzilla.kernel.org/show_bug.cgi?id=31522#c35 * https://bugs.freedesktop.org/show_bug.cgi?id=44156 * https://bugzilla.kernel.org/show_bug.cgi?id=53881 See also this bug and the plethora of duplicates: * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/765438 References: https://bugzilla.kernel.org/show_bug.cgi?id=54171 Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-)