| Message ID | 1380282522-27826-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks good. Reviewed-by: Todd Previte <tprevite@gmail.com> On Fri, Sep 27, 2013 at 4:48 AM, Jani Nikula <jani.nikula@intel.com> wrote: > Detailed cap info at address 80h is not available with DPCD ver > 1.0. Whether such devices exist in the wild I don't know, but there > should be no harm done in having the defines for downstream port 0 in > address 05h. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_dp_helper.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index ae8dbfb..83da4eb 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -77,10 +77,10 @@ > #define DP_DOWNSTREAMPORT_PRESENT 0x005 > # define DP_DWN_STRM_PORT_PRESENT (1 << 0) > # define DP_DWN_STRM_PORT_TYPE_MASK 0x06 > -/* 00b = DisplayPort */ > -/* 01b = Analog */ > -/* 10b = TMDS or HDMI */ > -/* 11b = Other */ > +# define DP_DWN_STRM_PORT_TYPE_DP (0 << 1) > +# define DP_DWN_STRM_PORT_TYPE_ANALOG (1 << 1) > +# define DP_DWN_STRM_PORT_TYPE_TMDS (2 << 1) > +# define DP_DWN_STRM_PORT_TYPE_OTHER (3 << 1) > # define DP_FORMAT_CONVERSION (1 << 3) > # define DP_DETAILED_CAP_INFO_AVAILABLE (1 << 4) /* DPI */ > > -- > 1.7.9.5 > >
On Fri, Sep 27, 2013 at 7:48 AM, Jani Nikula <jani.nikula@intel.com> wrote: > Detailed cap info at address 80h is not available with DPCD ver > 1.0. Whether such devices exist in the wild I don't know, but there > should be no harm done in having the defines for downstream port 0 in > address 05h. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > include/drm/drm_dp_helper.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index ae8dbfb..83da4eb 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -77,10 +77,10 @@ > #define DP_DOWNSTREAMPORT_PRESENT 0x005 > # define DP_DWN_STRM_PORT_PRESENT (1 << 0) > # define DP_DWN_STRM_PORT_TYPE_MASK 0x06 > -/* 00b = DisplayPort */ > -/* 01b = Analog */ > -/* 10b = TMDS or HDMI */ > -/* 11b = Other */ > +# define DP_DWN_STRM_PORT_TYPE_DP (0 << 1) > +# define DP_DWN_STRM_PORT_TYPE_ANALOG (1 << 1) > +# define DP_DWN_STRM_PORT_TYPE_TMDS (2 << 1) > +# define DP_DWN_STRM_PORT_TYPE_OTHER (3 << 1) > # define DP_FORMAT_CONVERSION (1 << 3) > # define DP_DETAILED_CAP_INFO_AVAILABLE (1 << 4) /* DPI */ > > -- > 1.7.9.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index ae8dbfb..83da4eb 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -77,10 +77,10 @@ #define DP_DOWNSTREAMPORT_PRESENT 0x005 # define DP_DWN_STRM_PORT_PRESENT (1 << 0) # define DP_DWN_STRM_PORT_TYPE_MASK 0x06 -/* 00b = DisplayPort */ -/* 01b = Analog */ -/* 10b = TMDS or HDMI */ -/* 11b = Other */ +# define DP_DWN_STRM_PORT_TYPE_DP (0 << 1) +# define DP_DWN_STRM_PORT_TYPE_ANALOG (1 << 1) +# define DP_DWN_STRM_PORT_TYPE_TMDS (2 << 1) +# define DP_DWN_STRM_PORT_TYPE_OTHER (3 << 1) # define DP_FORMAT_CONVERSION (1 << 3) # define DP_DETAILED_CAP_INFO_AVAILABLE (1 << 4) /* DPI */
Detailed cap info at address 80h is not available with DPCD ver 1.0. Whether such devices exist in the wild I don't know, but there should be no harm done in having the defines for downstream port 0 in address 05h. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- include/drm/drm_dp_helper.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)