diff mbox

drm/i915/vlv: reduce GT FIFO error info to a debug message

Message ID 1380303654-2060-1-git-send-email-jbarnes@virtuousgeek.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jesse Barnes Sept. 27, 2013, 5:40 p.m. UTC
It indicates a probable BIOS bug, but it appears to be harmless, and
there's nothing the user can do about it anyway, so reduce to a debug
msg.  I've filed a bug with the BIOS folks about it anyway, so hopefully
they'll fix whatever GT SB read they were doing when the GT was off.

References: https://bugs.freedesktop.org/show_bug.cgi?id=69396
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Daniel Vetter Sept. 27, 2013, 7:45 p.m. UTC | #1
On Fri, Sep 27, 2013 at 10:40:54AM -0700, Jesse Barnes wrote:
> It indicates a probable BIOS bug, but it appears to be harmless, and
> there's nothing the user can do about it anyway, so reduce to a debug
> msg.  I've filed a bug with the BIOS folks about it anyway, so hopefully
> they'll fix whatever GT SB read they were doing when the GT was off.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=69396
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Since it's vlv-specific code I guess this makes sense. Queued for -next,
thanks for the patch.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 102fc49..10054b5 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3804,7 +3804,8 @@  static void valleyview_enable_rps(struct drm_device *dev)
 	WARN_ON(!mutex_is_locked(&dev_priv->rps.hw_lock));
 
 	if ((gtfifodbg = I915_READ(GTFIFODBG))) {
-		DRM_ERROR("GT fifo had a previous error %x\n", gtfifodbg);
+		DRM_DEBUG_DRIVER("GT fifo had a previous error %x\n",
+				 gtfifodbg);
 		I915_WRITE(GTFIFODBG, gtfifodbg);
 	}