diff mbox

build: Skip kms_fbc_crc on Android

Message ID 1386084941-15704-1-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Dec. 3, 2013, 3:35 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

We do not have GLib there so it does not build.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/Android.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Dec. 3, 2013, 3:40 p.m. UTC | #1 
On Tue, Dec 03, 2013 at 03:35:41PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> We do not have GLib there so it does not build.

What dependence on GLib would that be?
-Chris
Tvrtko Ursulin Dec. 3, 2013, 4:06 p.m. UTC | #2 
On Tue, 2013-12-03 at 15:40 +0000, Chris Wilson wrote:
> On Tue, Dec 03, 2013 at 03:35:41PM +0000, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > We do not have GLib there so it does not build.
> 
> What dependence on GLib would that be?

Haven't looked further than the header it includes - you are saying it
doesn't need it?

Tvrtko
Daniel Vetter Dec. 3, 2013, 4:54 p.m. UTC | #3 
On Tue, Dec 03, 2013 at 04:06:51PM +0000, Tvrtko Ursulin wrote:
> On Tue, 2013-12-03 at 15:40 +0000, Chris Wilson wrote:
> > On Tue, Dec 03, 2013 at 03:35:41PM +0000, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > 
> > > We do not have GLib there so it does not build.
> > 
> > What dependence on GLib would that be?
> 
> Haven't looked further than the header it includes - you are saying it
> doesn't need it?

I've applied it for now. Imo we need to look at the entire pile of kms_
tests for android and figure out how to make those work.
-Daniel
diff mbox

Patch

diff --git a/tests/Android.mk b/tests/Android.mk
index ec64acd..c96f30a 100644
--- a/tests/Android.mk
+++ b/tests/Android.mk
@@ -65,6 +65,7 @@  skip_tests_list := \
     kms_cursor_crc \
     kms_flip \
     kms_pipe_crc_basic \
+    kms_fbc_crc \
     kms_render \
     kms_setmode \
     pm_pc8 \