diff mbox

[Intel,gfx,i-g-t,2/4] rendercopy/bdw: Set Instruction Buffer size Modify Enable to 1

Message ID 1386320087-3017-2-git-send-email-haihao.xiang@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xiang, Haihao Dec. 6, 2013, 8:54 a.m. UTC 
From: "Xiang, Haihao" <haihao.xiang@intel.com>

Otherwise it may result in GPU hang

Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
---
 lib/rendercopy_gen8.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kenneth Graunke Dec. 6, 2013, 10:15 a.m. UTC | #1 
On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> From: "Xiang, Haihao" <haihao.xiang@intel.com>
> 
> Otherwise it may result in GPU hang
> 
> Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> ---
>  lib/rendercopy_gen8.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
> index 43e962c..1a137dd 100644
> --- a/lib/rendercopy_gen8.c
> +++ b/lib/rendercopy_gen8.c
> @@ -526,7 +526,7 @@ gen8_emit_state_base_address(struct intel_batchbuffer *batch) {
>  	/* indirect object buffer size */
>  	OUT_BATCH(0xfffff000 | 1);
>  	/* intruction buffer size */
> -	OUT_BATCH(1 << 12);
> +	OUT_BATCH(1 << 12 | 1);
>  }
>  
>  static void
> 

Thanks a ton for finding this!

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Lespiau, Damien Dec. 6, 2013, 1:08 p.m. UTC | #2 
On Fri, Dec 06, 2013 at 02:15:18AM -0800, Kenneth Graunke wrote:
> On 12/06/2013 12:54 AM, Xiang, Haihao wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> > 
> > Otherwise it may result in GPU hang
> > 
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > ---
> >  lib/rendercopy_gen8.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
> > index 43e962c..1a137dd 100644
> > --- a/lib/rendercopy_gen8.c
> > +++ b/lib/rendercopy_gen8.c
> > @@ -526,7 +526,7 @@ gen8_emit_state_base_address(struct intel_batchbuffer *batch) {
> >  	/* indirect object buffer size */
> >  	OUT_BATCH(0xfffff000 | 1);
> >  	/* intruction buffer size */
> > -	OUT_BATCH(1 << 12);
> > +	OUT_BATCH(1 << 12 | 1);
> >  }
> >  
> >  static void
> > 
> 
> Thanks a ton for finding this!
> 
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Nice catch! Thanks for the patch and review, pushed.
diff mbox

Patch

diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
index 43e962c..1a137dd 100644
--- a/lib/rendercopy_gen8.c
+++ b/lib/rendercopy_gen8.c
@@ -526,7 +526,7 @@  gen8_emit_state_base_address(struct intel_batchbuffer *batch) {
 	/* indirect object buffer size */
 	OUT_BATCH(0xfffff000 | 1);
 	/* intruction buffer size */
-	OUT_BATCH(1 << 12);
+	OUT_BATCH(1 << 12 | 1);
 }
 
 static void